- Issue created by @balsama
- πΊπΈUnited States balsama boston
Actually, #3439702: Allow CLI install of Drupal using recipes β is just one reason the install profile might be `FALSE`. π Install profile is disabled for lots of different reasons and core doesn't allow for that Fixed acknowledged that there are other reasons too.
- Status changed to Needs work
7 months ago 6:22pm 7 May 2024 - πΊπΈUnited States anilu@ Houston, TX
Title and Description needs clarifying:
- Define a clear goal for this ticket
- Summarize information from other tickets instead of just past the issue link
- Complete the Problem/motivation
- Find a good title that is easy to understand
- Create steps to reproduce that can be follow by a developer - First commit to issue fork.
- Status changed to Needs review
7 months ago 7:39pm 7 May 2024 - πΊπΈUnited States phenaproxima Massachusetts
I think the issue summary seems pretty clear.
I'm putting this right at needs review because I don't think it would really stand to benefit from explicit test coverage, which would be complicated to write.
- Status changed to RTBC
7 months ago 8:07pm 7 May 2024 - π¬π§United Kingdom longwave UK
Given the API change documented in π Install profile is disabled for lots of different reasons and core doesn't allow for that Fixed the fix here is obvious so I also think this can go in without tests.
- πΊπΈUnited States balsama boston
+1 Manually tested with starshot and standard. Both recipes install as expected using php `./core/scripts/drupal install ` with this MR.
-
larowlan β
committed d10a3b77 on 10.3.x
Issue #3445791 by balsama, phenaproxima: Language module...
-
larowlan β
committed d10a3b77 on 10.3.x
-
larowlan β
committed a3a637ed on 10.4.x
Issue #3445791 by balsama, phenaproxima: Language module...
-
larowlan β
committed a3a637ed on 10.4.x
-
larowlan β
committed c07df939 on 11.0.x
Issue #3445791 by balsama, phenaproxima: Language module...
-
larowlan β
committed c07df939 on 11.0.x
-
larowlan β
committed b4f1d1a3 on 11.x
Issue #3445791 by balsama, phenaproxima: Language module...
-
larowlan β
committed b4f1d1a3 on 11.x
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Committed to 11.x and backported to 11.0.x, 10.4.x and 10.3.x
- Status changed to Fixed
7 months ago 10:05pm 7 May 2024 - π¬π§United Kingdom alexpott πͺπΊπ
FWIW testing this would have been quite simple - I think we could have to install a module in \Drupal\FunctionalTests\Installer\InstallerExistingConfigNoProfileTest and it would have crashed... ie add something like:
/** * {@inheritdoc} */ public function testConfigSync() { parent::testConfigSync(); // Ensure language_modules_installed() works without an install profile. $this->assertTrue(\Drupal::service('module_installer')->install(['syslog'])); }
I'll open a follow-up when I have time.
Automatically closed - issue fixed for 2 weeks with no activity.