- Issue created by @bnjmnm
- Status changed to Needs work
7 months ago 9:25pm 2 May 2024 - 🇫🇷France nod_ Lille
Agreed on having everything internal. Can we make the css-only libraries internal too? just in case. We can always make not internal for stable realease.
I would define floating ui as internal too, it's in the assets folder but it's not defined in core libraries hence shouldn't be relied upon just yet. I wouldn't want contrib to start depending on navigation/floating-ui. If we don't want to make that internal, that needs to go in core.libraries.yml
Other than that, +1
- 🇬🇧United Kingdom catch
+1 from me too. One question though - if the CSS libraries are marked internal, will that affect the Gin integration? Beta stability would allow us to make any CSS changes we like IMO whether the CSS libraries are internal or not.
- Status changed to RTBC
7 months ago 8:21am 3 May 2024 - 🇫🇮Finland lauriii Finland
It doesn't look like Gin is integrating with the Navigation through the libraries so it should be fine. I tested Gin manually with the patch and I didn't find any regressions.
- Status changed to Fixed
7 months ago 12:24pm 3 May 2024 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.4.x and 10.3.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.