- Issue created by @Balu Ertl
- First commit to issue fork.
- Merge request !51[1.0.x] β #3444915 β Allow enabling all metadata fields by one click β (Closed) created by nexusnovaz
- Status changed to Needs review
about 1 year ago 5:13pm 7 May 2024 - π¬π§United Kingdom nexusnovaz
Hi @Balu Ertl,
Changed the checkboxes to be a tableselect. Tested locally and it seems to work as intended. Please could you review #4
- Issue was unassigned.
- Status changed to Needs work
about 1 year ago 1:39pm 8 May 2024 - ππΊHungary Balu Ertl Budapest πͺπΊ
Hi Tyler, welcome to the Drupal Community! Thanks for picking up this issue. You started the right way but some further changes are still needed. Now tested the current MR and this is how it looked like to me:
The human labels of metadata fields in the rows display only their first character. This is because the core's
Tableselect
form element expects row data at an extra level deeper in the#options
array key. Also the#header
array key has to be under exactly the same name:
Now we have only one single column so I used βcolumnβ for the sake of simplicity. But the tech spec shows a clearer example of having multiple columns. Please apply the same changes so you should receive something like this:
Also, keep in mind that for the easiest way of testing, you need to authenticate your site to an Acquia DAM instance and check how the received data is being displayed. (If you have no access to an Acquia DAM system, then try mock the
$display_key_options
by filling up made up terms and check the rendered results.) - π¬π§United Kingdom nexusnovaz
Hi! Thank you for the welcome!
I've made a change to MR #51. I've now got a result like you do.
Thank you for the extra information and time you put into your response also!
Hopefully this is now looking and working as expected!
- Status changed to Needs review
about 1 year ago 7:18pm 9 May 2024 - Status changed to Needs work
7 months ago 8:21pm 7 October 2024 - ππΊHungary Balu Ertl Budapest πͺπΊ
As a feature improvement this should target branch
1.1.x
. The MR needs to be updated. - First commit to issue fork.
- Merge request !95#3444915 β Allow enabling all metadata fields by one click β (Merged) created by Balu Ertl
- ππΊHungary Balu Ertl Budapest πͺπΊ
baluertl β changed the visibility of the branch 1.1.x to hidden.
- ππΊHungary Balu Ertl Budapest πͺπΊ
baluertl β changed the visibility of the branch 3444915-allow-enabling-all to hidden.
- ππΊHungary Balu Ertl Budapest πͺπΊ
- Port changes from MR !51 to branch
1.1.x
as MR !95 - Remove the unnecessary Form title override, use the Page title from the routing itself instead
- Delete the unnecessary fieldset form element
- Replace instructions with a much more informative description about the purpose of this page
- Invoke the parent form logic to allow alteration by anyone else
- Use the action button inherited from the parent form controller
- Do not render the form if there is no metadata from the Widen API
Current implementation:
- Port changes from MR !51 to branch
-
japerry β
committed b2d3f375 on 1.1.x authored by
baluertl β
Issue #3444915 by baluertl, nexusnovaz: Allow enabling all metadata...
-
japerry β
committed b2d3f375 on 1.1.x authored by
baluertl β
Automatically closed - issue fixed for 2 weeks with no activity.