Allow enabling all metadata fields by one click

Created on 2 May 2024, about 2 months ago
Updated 9 May 2024, about 1 month ago

Use TableSelect form element on the /admin/config/acquia-dam/metadata page.

✨ Feature request
Status

Needs review

Version

1.1

Component

User interface

Created by

πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Balu Ertl
  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί
  • First commit to issue fork.
  • Merge request !51Issue #3444915: "Allow enabling all" β†’ (Open) created by NexusNovaz
  • Status changed to Needs review about 1 month ago
  • πŸ‡¬πŸ‡§United Kingdom NexusNovaz

    Hi @Balu Ertl,

    Changed the checkboxes to be a tableselect. Tested locally and it seems to work as intended. Please could you review #4

  • Pipeline finished with Failed
    about 1 month ago
    Total: 2965s
    #166579
  • Pipeline finished with Failed
    about 1 month ago
    Total: 2932s
    #166594
  • Issue was unassigned.
  • Status changed to Needs work about 1 month ago
  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί

    Hi Tyler, welcome to the Drupal Community! Thanks for picking up this issue. You started the right way but some further changes are still needed. Now tested the current MR and this is how it looked like to me:

    The human labels of metadata fields in the rows display only their first character. This is because the core's Tableselect form element expects row data at an extra level deeper in the #options array key. Also the #header array key has to be under exactly the same name:

    Now we have only one single column so I used β€œcolumn” for the sake of simplicity. But the tech spec shows a clearer example of having multiple columns. Please apply the same changes so you should receive something like this:

    Also, keep in mind that for the easiest way of testing, you need to authenticate your site to an Acquia DAM instance and check how the received data is being displayed. (If you have no access to an Acquia DAM system, then try mock the $display_key_options by filling up made up terms and check the rendered results.)

  • πŸ‡¬πŸ‡§United Kingdom NexusNovaz

    Hi! Thank you for the welcome!

    I've made a change to MR #51. I've now got a result like you do.

    Thank you for the extra information and time you put into your response also!

    Hopefully this is now looking and working as expected!

  • Status changed to Needs review about 1 month ago
  • πŸ‡¬πŸ‡§United Kingdom NexusNovaz
  • Pipeline finished with Failed
    about 1 month ago
    Total: 3135s
    #169063
  • Pipeline finished with Failed
    about 1 month ago
    Total: 2823s
    #170180
Production build 0.69.0 2024