- Issue created by @claudiu.cristea
- Assigned to claudiu.cristea
- Status changed to Needs review
12 months ago 12:30pm 26 April 2024 - π·π΄Romania claudiu.cristea Arad π·π΄
Unfortunately, new PHPCS rules forced me to drop support for PHP 7.4, otherwise the D9 test is failing. I will the module maintainers to weight on this but keep in mind that PHP 7.4 EOL was November 28, 2022
- Issue was unassigned.
- Status changed to RTBC
12 months ago 12:04pm 29 April 2024 - π΅πΉPortugal dxvargas
I've tested it and read the code changed, it's fine. I'll mark it as RTBC.
Not sure if it's a bug but anyways it's a good improvement. - π·π΄Romania claudiu.cristea Arad π·π΄
Thank you for review.
Not sure if it's a bug but anyways it's a good improvement.
Well, if it's not a bug, then this module should state that per-role timeouts can be assigned to any role except for users with no roles (i.e., users with ONLY
authenticated
role). But this is not documented anywhere accompanied with a good reason, so I still think it's a bug because I cannot configure specific timeouts for these kind of roles. Of course you can letauthenticated
-only users to fallback to default timeout but you cannot set them as "NO AUTOLOGOUT", while having other roles that you want to fallback to default. - πΊπΈUnited States jrglasgow Idaho
The fork appears to have merge conflicts, please fix and I will merge them in.
- π·π΄Romania claudiu.cristea Arad π·π΄
@jrglasgow, fixed conflicts and changed to 2.x (spell, phpstan, eslint are failing same as in current 2.x)
- First commit to issue fork.
-
japerry β
committed cb6f9100 on 2.x authored by
claudiu.cristea β
Issue #3443711 by claudiu.cristea: Users with no roles are logged out
-
japerry β
committed cb6f9100 on 2.x authored by
claudiu.cristea β
-
japerry β
committed cb6f9100 on 8.x-1.x authored by
claudiu.cristea β
Issue #3443711 by claudiu.cristea: Users with no roles are logged out
-
japerry β
committed cb6f9100 on 8.x-1.x authored by
claudiu.cristea β
Automatically closed - issue fixed for 2 weeks with no activity.