Update to new starterkit.yml file

Created on 25 April 2024, 8 months ago
Updated 14 August 2024, 4 months ago

Problem/Motivation

Recently with Drupal 10.3 a new starterkit.yml file has been introduced as mentioned here โ†’ . The generate-theme command will now look for a theme_name.starterkit.yml file within the theme's root, this replaces the starterkit: true within the themeโ€™s info.yml file.

The theme generator command will loop through all files and filenames and do a string replace of the machine_name of the starterkit theme with the machine_name of the new theme which may mean we can reduce some of the work being leveraged by our custom generator.

Proposed resolution

Create starterkit.yml file and remove key in info.yml file
Review and test generator for new options provided by the yml file.

๐Ÿ“Œ Task
Status

Fixed

Version

5.0

Component

Code

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States jldust

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jldust
  • Merge request !139Resolve #3443348 "Update to new" โ†’ (Merged) created by jldust
  • Status changed to Needs review 5 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States jldust
  • First commit to issue fork.
  • Status changed to RTBC 4 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States pixelwhip

    Thanks for working on this @jldust. For some reason the /tests folder wasn't getting removed despite it being in the ignore list. I added a work around for that. For some reason the Cypress tests that test the generated theme aren't passing on Tugboat despite them passing locally. Manually testing the changes works. There are some commits I've added that help address the issue but it still isn't fully passing. I don't want to hold this change up any longer though so I'm going to pause here. I think this is good to go otherwise.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States b-ry

    @jdust I tested this and it looks good to me. Works great!

  • Pipeline finished with Skipped
    4 months ago
    #253352
    • jldust โ†’ committed 30247f1c on 5.x
      Issue #3443348 by pixelwhip, jldust, b-ry: Update to new starterkit.yml...
  • Status changed to Fixed 4 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States jldust

    Thanks for testing this, I agree about merging this in and creating another ticket to resolve the Cypress testing issues.

  • Status changed to Fixed 4 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States jldust
Production build 0.71.5 2024