ConfigureBlockFormBase::getPluginForm() can return the wrong type

protected function getPluginForm(BlockPluginInterface $block) { if ($block instanceof PluginWithFormsInterface) { return $this->pluginFormFactory->createInstance($block, 'configure'); } return $block; }

Comments & Activities

Issue created by @joachim
Comment 7 months ago →
🇮🇳India pradhumanjainOSL
pradhumanjain2311 → made their first commit to this issue’s fork.
Merge request !7692Issue #3443122: ConfigureBlockFormBase::getPluginForm() can return the wrong type → (Open) created by Unnamed author
Pipeline finished with Success
7 months ago
Total: 1051s
#155295
Comment 7 months ago →
🇬🇧United Kingdom joachim
I'm not sure that changing the docs is the right fix.

What's the logic behind returning this?

None of the calls to this method handle the possibility that it's a BlockPluginInterface, so if ever that is returned, things will crash.
Comment 7 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co... BlockBase implements this interface but I think BlockPluginInterface should extend it instead. We can make that change under the 1:1 rule

ConfigureBlockFormBase::getPluginForm() can return the wrong type

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!7692ConfigureBlockFormBase::getPluginForm() can return the wrong type
Open

Comments & Activities

ConfigureBlockFormBase::getPluginForm() can return the wrong type

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!7692ConfigureBlockFormBase::getPluginForm() can return the wrong typeOpen

Comments & Activities

!7692ConfigureBlockFormBase::getPluginForm() can return the wrong type
Open