[1.0.x] Session Invalidator

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml session_invalidator/

FILE: session_invalidator/session_invalidator.module
------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------
 31 | WARNING | [ ] Line exceeds 80 characters; contains 98 characters
 35 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 47 | WARNING | [ ] Line exceeds 80 characters; contains 105 characters
 51 | ERROR   | [x] Expected newline after closing brace
 52 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters
 56 | ERROR   | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------

FILE: session_invalidator/src/EventSubscriber/PasswordChangeListener.php
-------------------------------------------------------------------------------
FOUND 13 ERRORS AND 2 WARNINGS AFFECTING 13 LINES
-------------------------------------------------------------------------------
  6 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Session\AccountProxyInterface.
 10 | WARNING | [x] Unused use statement
 12 | ERROR   | [x] Missing class doc comment
 14 | ERROR   | [ ] Missing member variable doc comment
 15 | ERROR   | [ ] Missing member variable doc comment
 16 | ERROR   | [ ] Missing member variable doc comment
 18 | ERROR   | [x] Missing function doc comment
 24 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 24 | ERROR   | [x] Missing function doc comment
 25 | WARNING | [ ] Line exceeds 80 characters; contains 129 characters
 28 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 0
 28 | ERROR   | [x] Expected 1 blank line after function; 2 found
 31 | ERROR   | [x] Missing function doc comment
 49 | ERROR   | [x] Expected 1 blank line after function; 0 found
 50 | ERROR   | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------

2. FILE: session_invalidator.info.yml

package: Custom

This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.

core_version_requirement: ^8 || ^9 || ^10

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.

3. FILE: session_invalidator.module

/**
 * @file
 * Contains hooks for the Session Invalidator module.
 */

The description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us and it doesn't contain enough PHP code to really assess your skills as developer.

Have you created any other project on drupal.org (module, theme, distribution) we could instead review? The project needs to have most of the commits (preferable all the commits) done by you.

The PasswordChangeListener class duplicates code that the .module file already executes, which means the PHP code used from the module is less than the code currently written.

I am changing priority as per Issue priorities → .

This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.