Incompatible with Drupal 10.3 and higher

Created on 22 April 2024, 8 months ago
Updated 21 June 2024, 6 months ago

Problem/Motivation

https://www.drupal.org/project/drupal/issues/3388913 🐛 Media library modal field widget does not render selection checkbox after search Active introduces a breaking change, by required the $row->mid property be set for rendering src/Plugin/views/field/MediaLibrarySelectForm.php.

The current class does not provide an MID, since the entity is external to Drupal. This causes a fatal error when using the module's media library,

It also affects 1.1-dev.

Steps to reproduce

Install 10.3. Try to use the module.

Proposed resolution

Fix the broken class

Remaining tasks

Fix the broken class

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States agentrickard Georgia (US)

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @agentrickard
  • Status changed to Needs review 8 months ago
  • 🇺🇸United States agentrickard Georgia (US)
  • Pipeline finished with Failed
    8 months ago
    Total: 1734s
    #153551
  • Pipeline finished with Failed
    8 months ago
    Total: 1884s
    #153553
  • 🇺🇸United States japerry KVUO

    Ohh, thanks for catching that Ken! I've escalated it internally so we can get it fixed in both 1.0 and the upcoming 1.1 release.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
    last update 8 months ago
    Composer require-dev failure
  • 🇺🇸United States japerry KVUO

    Looking at views_remote_data as well -- since I'm guessing any derivative plugin will have this issue as well.

  • Pipeline finished with Failed
    8 months ago
    Total: 1670s
    #157786
  • 🇺🇸United States agentrickard Georgia (US)

    Maybe -- though I haven't run into that yet.

  • Pipeline finished with Failed
    8 months ago
    Total: 3332s
    #162805
  • Pipeline finished with Failed
    8 months ago
    Total: 3134s
    #162851
  • Status changed to Needs work 8 months ago
  • 🇺🇸United States japerry KVUO

    Okay I spent some time on this today, and this issue is a doozy.

    1) This -will- break 10.2 and earlier, unless a BC shim is added. This will be necessary before committing.
    2) The tests (automated and manual) are failing because of the change. Interestingly, the dev tests say they are passing, but if you look at the debug output they are also failing for 10.3.
    3) I'm a little leary of using the uuid from the asset as the mid because a) there is an associated mid after it is created and b) not sure how non-numeric indexes work here.

    So I'm a bit worried about how we handle this missing media id in the view. Will try to get Matt's time to look at it sometime later in May, but before Drupal 10.3 comes out.

  • First commit to issue fork.
  • 🇺🇸United States mglaman WI, USA

    Cherry-picked commit from https://git.drupalcode.org/project/acquia_dam/-/merge_requests/47 which fixes the mock handler and should clear up some errors.

  • Pipeline finished with Failed
    8 months ago
    Total: 3007s
    #163745
  • Pipeline finished with Failed
    7 months ago
    Total: 1304s
    #175399
  • Pipeline finished with Failed
    7 months ago
    Total: 2538s
    #192112
  • Pipeline finished with Failed
    7 months ago
    Total: 2918s
    #192205
  • Pipeline finished with Failed
    7 months ago
    Total: 2477s
    #193267
  • Pipeline finished with Failed
    7 months ago
    Total: 2547s
    #193283
  • Pipeline finished with Failed
    7 months ago
    Total: 2611s
    #193815
  • Pipeline finished with Success
    7 months ago
    Total: 1145s
    #193843
  • Pipeline finished with Skipped
    7 months ago
    #193894
  • Status changed to Fixed 7 months ago
  • 🇺🇸United States japerry KVUO

    Fixed!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024