DateRangeFieldTest should not use a data provider

Drupal\Tests\datetime_range\Functional\DateRangeFieldFromToTest 27 passes - still over 5 minutes.

Might need to do this without a data provider and handle the 27 variations with the test itself.

Sometimes you just need a foreach loop.

Locally the test finishes in 30 seconds, now, so approximately 1/20th the time.

This is fast enough it's fine in the main class now, moved back and re-titling. So the only change here is to use a foreach loop for each variation instead of a full install of Drupal each time.

I ran the test, just once, results below, with and without the diff and I reviewed the MR. I am not fond on describing methods as 'helpers' and I left a suggestion in the MR.

Before
real 8m11.738s
user 0m0.077s
sys 0m0.054s

After
real 0m23.966s
user 0m0.068s
sys 0m0.014s

Love it. I do stuff like this a lot in tests. I basically can't stand to see data providers in Functional tests, and heaven-forbid in FunctionalJavaScript.

The results in #8 are mind blowing, given the small size of the diff. 8:11 to 0:24 is more than a 20X speedup. 😂

Ship it!

Thanks,
-Derek

I do like using less resources to do task.

Committed and pushed to 11.x and 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.