- Issue created by @koosvdkolk
- Status changed to Needs review
about 1 year ago 12:33am 8 June 2024 - 🇺🇸United States damienmckenna NH, USA
But they're inside <code> blocks, shouldn't it be ok?
That said, how does this work?
The tips defined in the following code contain invalid HTML
public function tips($long = FALSE) {
if ($long) {
return $this->t('
<p>Applies the resizing on embedded media images inside ckeditor5 generated content when rendering the ckeditor content in Drupal.</p>
<p>This works via a the data-media-width attribute on <drupal-media> tags, for example: <drupal-media data-media-width="50%".</p>
');
}
else {
return $this->t('You can resize media images by adding the data-media-width attribute on <drupal-media> tags, for example: <drupal-media data-media-width="50%".');
}
}
The <drupal-media> tags are not being closed properly, which breaks downstream HTML.
Solution
<drupal-media> should become <drupal-media />
Needs review
1.0
Code
But they're inside <code> blocks, shouldn't it be ok?
That said, how does this work?