- Issue created by @adinac
- Status changed to Postponed: needs info
7 months ago 6:33pm 18 April 2024 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Do you have any custom preprocessing?
Does this happen with a core theme? - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Please see π Link attributes not working after upgrading Drupal core from 10.2.2 to 10.2.3 Closed: works as designed
- Status changed to Active
7 months ago 6:44am 19 April 2024 - π·π΄Romania adinac
I have seen that issue and no, we don't have any custom preprocessing for links.
- Status changed to Postponed: needs info
7 months ago 5:50am 20 April 2024 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
This module does not provide a formatter or do anything for output, it only provides a widget for editing.
Is the value there when you edit? If so the issue is in the theme or somewhere else - π·π΄Romania adinac
Since the attributes get lost in the LinkitFormatter viewElements() when the url is overwritten for entity links ($url = $this->getSubstitutedUrl($link_item)), I decided to move this issue to the linkit module.
- Status changed to Active
7 months ago 1:51pm 23 April 2024 - Status changed to Needs work
7 months ago 11:48pm 29 April 2024 - πΊπΈUnited States mark_fullmer Tucson
Thanks for reporting this! Can you provide steps to reproduce? Ideally, we can use those to model new test coverage to ensure that attributes don't go missing again!
- Merge request !51Issue #3441789 by adinac, mark_fullmer: Link attributes are not set for linkit... β (Merged) created by mark_fullmer
- Status changed to Needs review
7 months ago 9:08pm 8 May 2024 - πΊπΈUnited States mark_fullmer Tucson
I was aware of π Query string duplications Fixed and had commented on the implications for Linkit in https://www.drupal.org/project/drupal/issues/2885351#comment-15461298 π Query string duplications Fixed . We' addressed the problem for the two attributes supported by the Linkit formatter with π Add test coverage for rel and target settings Fixed , but I follow your hypothesis that other atttributes could be lost during the call to
$url = $this->getSubstitutedUrl($link_item)
.Adding a merge request that replicates the logic from #9, which no longer applies to 6.1.x
-
mark_fullmer β
committed e54f7c5a on 6.1.x
Issue #3441789 by mark_fullmer, adinac: Link attributes are not set for...
-
mark_fullmer β
committed e54f7c5a on 6.1.x
- Status changed to Fixed
7 months ago 9:14pm 8 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.