- Issue created by @mrshowerman
- Issue was unassigned.
- Status changed to Needs work
almost 2 years ago 3:45pm 26 March 2023 - π©πͺGermany mrshowerman Munich
Here's a first patch that brings back the attributes.
Could use some help with a test though. - Status changed to Needs review
almost 2 years ago 5:36pm 26 March 2023 - πΊπΈUnited States mark_fullmer Tucson
I'm not sure I'm able to reproduce the problem described in the 6.0.x branch. I've attached a patch that includes test coverage that demonstrates the the
rel
andtarget
values are reflected from the Linkit Formatter settings. - Status changed to Closed: works as designed
over 1 year ago 10:39am 27 March 2023 - π©πͺGermany mrshowerman Munich
I had another look and it seems the issue isn't in Linkit, but related to the patch from π Query string duplications Fixed , where the link item's #options is being reset to an empty array, in order to avoid duplicate query string parameters.
Sorry for the noise; I'll take a closer look at #2885351, maybe there's a better approach than the current one.
Not sure if this is the right status; maybe the test is still useful for detecting similar issues in the future. - Status changed to Needs review
over 1 year ago 2:11pm 27 March 2023 - πΊπΈUnited States mark_fullmer Tucson
Re-opening and updating the title to indicate that we can add test coverage to demonstrate this works as designed (and to flag a failure in π Query string duplications Fixed .
- Assigned to mmarler
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 5:27pm 31 March 2023 -
mark_fullmer β
committed 274ad127 on 6.0.x
Issue #3350477 by mrshowerman, mark_fullmer, mmarler: Add test coverage...
-
mark_fullmer β
committed 274ad127 on 6.0.x
-
mark_fullmer β
committed 274ad127 on 6.1.x
Issue #3350477 by mrshowerman, mark_fullmer, mmarler: Add test coverage...
-
mark_fullmer β
committed 274ad127 on 6.1.x
- Status changed to Fixed
over 1 year ago 9:48pm 31 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Active
10 months ago 8:29pm 24 February 2024 - πΊπΈUnited States mark_fullmer Tucson
With π Query string duplications Fixed added in Drupal 10.2.3, this is now a problem as it was originally reported by mrshowerman. The previously added test coverage IS now failing on Drupal 10.2.3. The original proposed patch resolves the issue.
- Merge request !44Issue #3350477 by mrshowerman, mark_fullmer: Linkit for Link Field: "rel" and... β (Merged) created by mark_fullmer
- last update
10 months ago 83 pass - last update
10 months ago 83 pass -
mark_fullmer β
committed 640b9b08 on 6.1.x
Issue #3350477 by mark_fullmer, mrshowerman: Linkit for Link Field: "rel...
-
mark_fullmer β
committed 640b9b08 on 6.1.x
- Status changed to Fixed
10 months ago 8:55pm 24 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.