- Issue created by @guiu.rocafort.ferrer
- Merge request !23Draft: Fix most phpcs code style standards → (Open) created by guiu.rocafort.ferrer
- 🇪🇸Spain guiu.rocafort.ferrer Barcelona
I've managed to fix all the phpcs errors except for one.
--------------------------------------------------------------------------------
167 | ERROR | All functions defined in a module file must be prefixed with the
| | module's name, found "coordinates_dd_to_dms" but expected
| | "smart_ip_coordinates_dd_to_dms"
| | (Drupal.NamingConventions.ValidFunctionName.InvalidPrefix)
--------------------------------------------------------------------------------I am a bit concerned that changing that function name might break other contrib / custom modules that make use of it, so i am not sure about what might be the best approach for this.
I am thinking that when a new version including this change comes out, it should at least have a change notice, specifying that this function have changed name. Not sure if this is such big of a deal, but want to know what the mantainers position is in that matter.
- Status changed to Needs work
8 months ago 4:50pm 24 April 2024 - 🇪🇸Spain guiu.rocafort.ferrer Barcelona
Changing the ticket status to needs work.