User icon in toolbar disappears on medium screens

Created on 17 April 2024, 5 months ago
Updated 28 April 2024, 5 months ago

Problem/Motivation

Visit any page as logged in user, shrink your browser window under 80em (when the user name in the user menu is supposed to disappear) and the user icon will disappear.

The problem is caused by a font-size: 0 in

@media (min-width: 61em)
.gin-secondary-toolbar .toolbar-secondary .toolbar-bar .toolbar-tab .toolbar-item {

For even smaller screens, under 61em, both the icon and user name are back, so no issue there.

Proposed resolution

Add a font-size: initial to the ::before element (where the icon is), like:

.toolbar.toolbar-secondary .toolbar-bar .toolbar-tab > .toolbar-icon::before, .toolbar.toolbar-secondary .toolbar-bar .toolbar-tab > .responsive-preview-icon::before {
    background-color: var(--gin-icon-color);
    font-size: initial;
}

You will notice the icon is not centered in the dropdown, so this is also probably wrong:

@media (min-width: 61em)
[dir="ltr"] .gin-secondary-toolbar .toolbar-secondary .toolbar-bar .toolbar-tab .toolbar-item:before {
    left: 10px;
}

Given current settings it should be left: 4px.

Remaining tasks

Provide MR

๐Ÿ› Bug report
Status

RTBC

Version

3.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡นItaly kopeboy Milan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024