[2.0.x-alpha2] Follow-up Field Formatters

Musa.thomas → made their first commit to this issue’s fork.

For this point :

Mapping is done on field types instead of field property types

We have mapping of all property core type describe here:
https://www.drupal.org/docs/drupal-apis/entity-api/fieldtypes-fieldwidge... →
Each field property type are define with a schema data type define inside schema method:
https://www.drupal.org/docs/creating-custom-modules/creating-custom-fiel... →
I also commit a "fallback" to this schema data if we don't match in our first mapping of property field.

Why we don't want to map directly/only on schema type ?

The schema type is less adapted to our prop type (less precise) for example an field with boolean property is defined as "int" "tiny", and also we want to map boolean to boolean and not to integer.
https://www.drupal.org/docs/7/api/schema-api/data-types/data-types-overview →
If you got better solution we can implement it.

Hi Thomas,

Let's talk about that in May, during work on Alpha 3.

I got a call with Mikael, he told me I am mixing up field types and prop types here. Maybe we need some rest and to wait a bit. The codebase is already in a good enough shape for now.

Mapping is done on field types instead of field property types

Move the logic out of FieldPropertiesSourcePropDeriver::getPropTypeToFieldTypeMap()

1. Add a new annotation to field types. Example:
   

    * @PropType(
    *   id = "string",
    ...
    *   typed_data = {
    *    "datetime_iso8601",
    *    "email",
    *    "string"
    *  }
    * )

2. Add a ui_patterns (not in ui_patterns_field_formatters) service or (a prop type plugins manager method) to get UI Patterns prop type(s) from a Drupal typed data.
3. Use this in FieldPropertiesSourcePropDeriver

See mapping in specs: https://docs.google.com/document/d/1-GaMK1Qk-h0hmB7GtAcnqPTuCOGMaxeRguop...

This will also be useful for TokenSource plugin.

Lets do

Musa.thomas → changed the visibility of the branch 3441326-2.0.x-alpha3-follow-up-field to hidden.

All fix except "FieldFormatter source" point

• Move the logic out of FieldPropertiesSourcePropDeriver::getPropTypeToFieldTypeMap() >> ✅
• Recursive FieldFormatter source >>> Moved to 📌 [2.0.0-alpha3] Form builder: Simpler sources selector (2/2) + make it nestable Needs work
• Field label appears inside other context >> ✅ I don't see this source in blocks anymore.
• Context: Why we need to get context value 'entity_type_id' and not get from the context 'entity' (fieldSourceBase line 92, ComponentFormatterBase line 121) >> this was not answered, but let's move on
• Description source settings >> ✅ no more early rendering

Merged

Automatically closed - issue fixed for 2 weeks with no activity.