Coding standard issues fixed

FILE: /var/www/html/drupal9.3.0/web/modules/contrib/keycloak/js/keycloak-session.js ---------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES ---------------------------------------------------------------------------------------------- 61 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 81 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 89 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 182 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 197 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 243 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" ---------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal9.3.0/web/modules/contrib/keycloak/src/Controller/KeycloakController.php -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------- 12 | ERROR | Use statements should be sorted alphabetically. The first wrong one is Drupal\openid_connect\Plugin\OpenIDConnectClientManager. -------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal9.3.0/web/modules/contrib/keycloak/src/Service/KeycloakServiceInterface.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 6 WARNINGS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 5 | WARNING | Unused use statement 6 | WARNING | Unused use statement 7 | WARNING | Unused use statement 8 | WARNING | Unused use statement 9 | WARNING | Unused use statement 10 | WARNING |Unused use statement 10 | ERROR | Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\TempStore\PrivateTempStoreFactory. ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal9.3.0/web/modules/contrib/keycloak/src/Service/KeycloakService.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------- 12 | ERROR | Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\TempStore\PrivateTempStoreFactory. ---------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal9.3.0/web/modules/contrib/keycloak/src/Plugin/OpenIDConnectClient/KeycloakRoleMatcherTrait.php ------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 16 | ERROR | Parameter $userInfo is not described in comment 21 | ERROR | Doc comment for parameter $userinfo does not match case of actual variable name $userInfo ------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal9.3.0/web/modules/contrib/keycloak/src/Plugin/OpenIDConnectClient/Keycloak.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AND 6 WARNINGS AFFECTING 13 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\EmailValidatorInterface. 241 | WARNING | [ ] Unused variable $index. 371 | WARNING | [ ] #options values usually have to run through t() for translation 372 | WARNING | [ ] #options values usually have to run through t() for translation 470 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 482 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 683 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 749 | ERROR | [ ] Parameter $userInfo is not described in comment 754 | ERROR | [ ] Doc comment for parameter $userinfo does not match case of actual variable name $userInfo 795 | ERROR | Space after closing parenthesis of function call prohibited 796 | ERROR | Space found before semicolon; expected ");" but found ")\n ;" 810 | ERROR | Space after closing parenthesis of function call prohibited 811 | ERROR | Space found before semicolon; expected ");" but found ")\n ;" ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal9.3.0/web/modules/contrib/keycloak/src/EventSubscriber/KeycloakRequestSubscriber.php ------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Language\LanguageInterface. 162 | WARNING | [x] A comma should follow the last multiline array item. Found: 35 ------------------------------------------------------------------------------------------------------------------------------------ Time: 234ms; Memory: 16MB

Comments & Activities

Issue created by @Rohit Rana
Issue was unassigned.
Status changed to Needs review 8 months ago11:13am 16 April 2024
Comment 8 months ago →
🇮🇳India Rohit Rana
Status changed to Needs work 8 months ago11:17am 16 April 2024
Comment 8 months ago →
🇧🇪Belgium BramDriesen Belgium 🇧🇪
First of all, no credits will be given for a ticket like this that can be automated.
Secondly, PHPCS does not apply to JS, e.g. the boolean changes in your patch are not okay.
Thirdly, this should be a merge request so that GitLab CI clearly shows there are no issues anymore.

Also linking the credit abuse policy as you should be aware of this: https://www.drupal.org/drupalorg/docs/marketplace/abuse-of-the-contribut... →

Opening PHPCS only fix tickets falls under credit abuse.

Coding standard issues fixed

Problem/Motivation

Comments & Activities