- Issue created by @karolinam
- π³πΏNew Zealand danielveza Brisbane, AU
This makes sense to me.
Rather than using a hook, is it possible to set the new admin label in
Drupal\layout_builder\Form\AddBlockForm::buildForm
instead?This will also need test coverage of the new label coming through. It seems like overkill to add an entire new test case for this, so maybe an assert for the new admin label could be added to
LayoutBuilderTest::testFieldBlockLabel
? - π¨π¦Canada karolinam
Thank you for your feedback and suggestions. I implemented the changes.
I set the new admin label inDrupal\layout_builder\Form\ConfigureBlockFormBase::doBuildForm
instead ofDrupal\layout_builder\Form\AddBlockForm::buildForm
because that's where the admin label is being set to "Block description" by$form['settings'] = $this->getPluginForm($this->block)->buildConfigurationForm($form['settings'], $subform_state);
- Status changed to RTBC
7 months ago 1:33pm 17 April 2024 - Status changed to Needs work
7 months ago 10:17pm 17 April 2024 - π³πΏNew Zealand danielveza Brisbane, AU
This is failing tests at the moment, they need to be passing before this can be RTBC
- π¨π¦Canada karolinam
It looks like these tests fail since the last commit in issue https://www.drupal.org/project/drupal/issues/3272629 π Media Library widget display doesn't return to first page on applying filters Needs work , pipeline: https://git.drupalcode.org/project/drupal/-/pipelines/143737
- πΊπΈUnited States xjm
Thanks for working on this. MRs should always be created against 11.x first, and will be backported to the appropriate versions once the issue is committed. (Sometimes, the cleanest thing to do is to close the old MR and open a fresh one against 11.x.) Thanks!