- Issue created by @mondrake
- Status changed to Needs review
8 months ago 4:27pm 14 April 2024 - Status changed to RTBC
8 months ago 8:42am 10 May 2024 - 🇳🇱Netherlands daffie
All the code changes look good to me.
The added code comments are clear.
For the different situations is testing added.
The testbot is green for all supported databases.
For me it is RTBC. - First commit to issue fork.
- Status changed to Needs work
7 months ago 4:00am 24 May 2024 - 🇳🇿New Zealand quietone
I read the issue summary and the MR. I did not do a code review, just the comments. I applied my own suggestions for minor grammar fixes. The comments on the whole make sense but I suggested some improvements. And I had a question about comments in the tests. I am going to set this to Needs Work so someone checks the suggestions.
I have added credit as well.
- Status changed to Needs review
7 months ago 10:03am 25 May 2024 - 🇮🇹Italy mondrake 🇮🇹
Applied @quietone suggestions, but then changed a bit again as I thought the end result was still not accurate. Not a native speaker, so please bear with me.
- 🇳🇿New Zealand quietone
@mondrake, thanks for updating the comments. They are much easier to understand now and will benefit those who come after us. Thanks!
I was about to restore the RTBC when I checked the tests. There is a failing test, core/tests/Drupal/FunctionalTests/Installer/InstallerTranslationExistingFileTest.php and I have restarted that set of functional tests. Once tests are passing this can go back to RTBC.
- Status changed to RTBC
7 months ago 11:17am 25 May 2024 - 🇮🇹Italy mondrake 🇮🇹
@quietone your change of the title text does no longer read. Unsure what you meant to change, so leaving as is.
- First commit to issue fork.
-
larowlan →
committed f276f6a9 on 11.x
Issue #3440848 by mondrake, quietone, daffie: Ensure post transaction...
-
larowlan →
committed f276f6a9 on 11.x
-
larowlan →
committed d07ed426 on 11.0.x
Issue #3440848 by mondrake, quietone, daffie: Ensure post transaction...
-
larowlan →
committed d07ed426 on 11.0.x
-
larowlan →
committed b54e7f4d on 10.4.x
Issue #3440848 by mondrake, quietone, daffie: Ensure post transaction...
-
larowlan →
committed b54e7f4d on 10.4.x
-
larowlan →
committed d322b132 on 10.3.x
Issue #3440848 by mondrake, quietone, daffie: Ensure post transaction...
-
larowlan →
committed d322b132 on 10.3.x
- Status changed to Fixed
5 months ago 10:32pm 21 July 2024 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Fixed a typo in a comment, waited for a green test-run - which passed.
Committed to 11.x and backported 11.0.x, 10.4.x and 10.3.xThanks folks 🙌
Automatically closed - issue fixed for 2 weeks with no activity.