- Issue created by @Anybody
- 🇦🇺Australia darvanen Sydney, Australia
Raising to Major, I definitely agree this shouldn't be happening by default.
I'd like existing sites to retain the "wrong" behaviour though rather than changing it for them, perhaps an update hook? I'll make sure the release note has a big note in it.
I won't get to this tonight, or possibly for a while. MRs welcome.
- Merge request !21Make user account validation rules configurable between create and update → (Merged) created by darvanen
- Status changed to Needs work
12 months ago 1:07pm 14 April 2024 - 🇦🇺Australia darvanen Sydney, Australia
Any feedback on these new config settings?
- 🇦🇺Australia darvanen Sydney, Australia
LOL wow, uploaded the wrong screenshot, this is the right one:
- 🇩🇪Germany Anybody Porta Westfalica
I agree this is major. Asking @Grevil to work on this. We can't use this module until it's fixed, it blocks existing users from editing their accounts. They can not even change their passwords.
- 🇦🇺Australia darvanen Sydney, Australia
@Anybody I made an MR, please try grabbing a patch from that? It only needs tests to be committed but feedback on the UI would be gratefully accepted. If @Grevil could sort out tests we'll have a release in no time.
- First commit to issue fork.
- Assigned to Grevil
- 🇩🇪Germany Grevil
I think the UI is good! The only point against "checkboxes", would be that we disable the module functionality through unchecking both of these. But I guess, there is a use case hidden in that feature as well! :P
So yea, LGTM! And code looks good as well! I'll quickly add schema and install file entries, create an update hook, and add / refactor (existing) tests!
- Issue was unassigned.
- Status changed to Needs review
12 months ago 2:07pm 17 April 2024 - Status changed to RTBC
12 months ago 10:20pm 17 April 2024 - 🇦🇺Australia darvanen Sydney, Australia
Wonderful, thank you.
I've just changed the update hook to set both to true for existing sites so they retain the functionality they already have.
-
darvanen →
committed 2eca5c05 on 1.x
Issue #3440590 by Grevil, darvanen, Anybody: Add option to only validate...
-
darvanen →
committed 2eca5c05 on 1.x
- Status changed to Fixed
12 months ago 10:21pm 17 April 2024 - 🇦🇺Australia darvanen Sydney, Australia
Release made, hope that unblocks you :)
While I was writing it up I realised we needed a follow-up for validation on email change: [#3441666)
Automatically closed - issue fixed for 2 weeks with no activity.