- Issue created by @swilmes
- First commit to issue fork.
- Merge request !163Adds view mode selector to LPBuilder and updates config schema. → (Merged) created by sethhill
- last update
10 months ago 55 pass - Status changed to RTBC
10 months ago 1:26pm 27 April 2024 - 🇺🇸United States sethhill
I added to the patch that @swilmes posted, displaying the view mode and preview mode by name. I also added the view_mode to the config schema and ensured that phpunit tests are still successful. This looks good from my perspective.
- Status changed to Fixed
10 months ago 3:49pm 15 May 2024 - last update
10 months ago 55 pass - last update
10 months ago 55 pass - Status changed to RTBC
10 months ago 2:02pm 22 May 2024 Thank you for the PR. We are using PR on a big customer website and its working fine for us.
RTBC +1
Looking forward to get this in soon :)-
sethhill →
committed 03a79acc on 2.0.x
git commit -m 'Issue #3440313 by sethhill, swilmes, jnettik: Allow View...
-
sethhill →
committed 03a79acc on 2.0.x
- Status changed to Fixed
9 months ago 2:12pm 6 June 2024 - Status changed to Fixed
9 months ago 4:58pm 7 June 2024 - 🇬🇧United Kingdom james.williams
What is the difference between the
view_modeandpreview_view_modesettings please? I only see the originalpreview_view_mode(andform_display_mode) making any difference. It looks to me as thoughpreview_view_modemakes the idea ofview_moderedundant, in which caseview_modeshould probably be removed?