[8.x-1.x] Translation Centre For the Bodies of the EU - Plugin for TMGMT

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. master is a wrong name for a branch and should be removed. Release branch names always end with the literal .x as described in Release branches.

2. Remove // @codingStandardsIgnoreStart and // @codingStandardsIgnoreEnd comments from the code to bypass coding standards validation and after that fix all the issues reported by PHPCS tool.

3. FILE: tmgmt_cdt.module

/**
 * @file
 * Module.
 */

The description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

/**
 * Implements hook_form_FORM_ID_alter().
 */
function tmgmt_cdt_form_tmgmt_translator_edit_form_alter(&$form, FormStateInterface $form_state, $form_id) {

/**
 * Implements hook_form_FORM_ID_alter().
 */
function tmgmt_cdt_form_tmgmt_overview_form_alter(&$form, FormStateInterface $form_state, $form_id) {

/**
 * Implements hook_form_FORM_ID_alter().
 */
function tmgmt_cdt_form_tmgmt_cart_form_alter(&$form, FormStateInterface $form_state, $form_id) {

/**
 * Implements hook_form_FORM_ID_alter().
 */
function tmgmt_cdt_form_tmgmt_content_translate_form_alter(&$form, FormStateInterface $form_state, $form_id) {

/**
 * Implements hook_form_FORM_ID_alter().
 */
function tmgmt_cdt_form_tmgmt_job_continuous_add_form_alter(&$form, FormStateInterface $form_state, $form_id) {

/**
 * Implements hook_form_FORM_ID_alter().
 */
function tmgmt_cdt_form_tmgmt_job_item_edit_form_alter(&$form, FormStateInterface $form_state, $form_id) {

/**
 * Implements hook_form_FORM_ID_alter().
 */
function tmgmt_cdt_form_tmgmt_job_edit_form_alter(&$form, FormState $form_state, $form_id) {

/**
 * Implements hook_form_FORM_ID_alter().
 */
function tmgmt_cdt_form_tmgmt_translator_overview_alter(&$form, FormStateInterface $form_state, $form_id) {

The description for this hook should also say for which form that hook is implemented, either by indicating that with the name of the class that implements the form (namespace included) or the form ID (which is usually indicated by getFormId()).

// $form['auto_accept']['#access'] = false;

Remove commented code.

4. Put below files in a config folder

views.view.tmgmt_job_items.yml
views.view.tmgmt_job_overview.yml
views.view.tmgmt_translation_all_job_items.yml

5. FILE: src/TmgmtCdtHelper.php

            } else {
                return false;
            }

As per Drupal coding standards, the else part needs to go in a new line.

6. FILE: src/TmgmtCdtApi.php

  /**
   * Constructor with defaut values.
   */
  public function __construct() {

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

7. FILE: src/TmgmtCdtApi.php

  private function checkTokenAccess()
  {

Drupal coding standards say function declarations are written on a single line.

// \Drupal::state()->set('tmgmt_cdt.ready', FALSE);

Remove commented code.

8. FILE: src/Plugin/tmgmt/Translator/TmgmtCdtTranslator.php

    /**
     * Constructor.
     *
     * @param array $configuration
     *   A configuration array containing information about the plugin instance.
     * @param string $pluginId
     *   The plugin ID for the plugin instance.
     * @param mixed $pluginDefinition
     *   The plugin implementation definition.
     */
    public function __construct(array $configuration, $pluginId, array $pluginDefinition)

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

    public function __construct(array $configuration, $pluginId, array $pluginDefinition)
    {

    public static function create(ContainerInterface $container, array $configuration, $pluginId, $pluginDefinition)
    {

Drupal coding standards say function declarations are written on a single line, even if they exceed 80 characters.

I applied the adjustments you recommended and commited to the branch 8.x-1.x

If you changed what has been reported, please change the status to Needs review. In this way, reviewers will know everything has been changed and can be reviewed again.

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

Thank you for your contribution!
I updated your account so you can now opt into security advisory coverage for any project you created and every project you will create.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !

Thank you for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank also the dedicated reviewers as well.

Automatically closed - issue fixed for 2 weeks with no activity.