Skip query string compression if zlib extension isn't available

This would be for 10.3.x and 10.2.x only.

Should MR be updated for 10.3.x

Normally yes but since the code in 11.x is identical and it's a trivial change, hoping not :) See what the committer who next finds this says.

Most of distros has zlib extension bundled into PHP sapi executable so it's tricky to build PHP without it.
Meantime thinking about how othe algo current and upcoming can be involved here.

Brotli already in every browser so such places should be centralized somehow

Hi, does it mean with this patch I can upgrade to 10.2x without need to install extenstion for php?

(I have to contact server team so they can help me with but that would mean i can use the latest drupal now which is covered by security until php extension is installed by our server team.)

Or i am mistaken and still have to install extension first so need to stuck on 10.0x for a while?

@coaston if you apply this patch, you'll be able to update, however you'll end up with very long query strings for CSS and JavaScript aggregates - this might be completely fine, but it might also run into hosting limits, will need some testing. I would recommend contacting your hosting support to ask for the extension to be installed anyway, since it will be better with that.

@andypost definitely worth opening an issue to see if we can use brotli compression here if it's available, I think we could just have a couple of code branches depending on what's available.

Hi @catch.

Thank you. However in my case it would be quite difficult as we do have our own server which is not directly connected to internet. So new extension for php would require more complex approach but at least we do have some time with this workaround.

And regarding long strings of CSS - do you thing this module → can help in this case?

@coaston @advagg won't help - it's made mostly irrelevant by the aggregation changes in 10.1.

📌 Only send libraries with aggregate URLs that have the aggregate type included Needs review will help a little bit.

Committed and pushed 26e9f32dfa to 11.x and cfabdf59d3 to 10.3.x and 6c9babd449 to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.