- Issue created by @Grevil
- Merge request !47Issue #3439626 by Grevil: Issues when creating homebox presets / other people's homeboxes → (Merged) created by Grevil
- Assigned to Anybody
- Status changed to Needs review
about 1 year ago 9:54am 11 April 2024 - Assigned to Grevil
- Status changed to Needs work
about 1 year ago 10:08am 11 April 2024 - 🇩🇪Germany Anybody Porta Westfalica
Nice work, but I'm not really sure the context parameter is the best possible solution.
I'm a bit more in favor of using inheritance and two different form classes inheritng from the base class.
That's typically the better polymorphysm pattern instead of if's that tend to grow by time and code becomes ugly.Furthermore, in the current implementation you have to ensure the context parameter is always present, which is also a sign of improvable design. In that case two separate same-based routes / URLs could do the job better without edge-cases like
- unexpected value for context
- missing context
which for routes the system would handle itself by design (404)
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 12:20pm 11 April 2024 - Status changed to RTBC
about 1 year ago 12:21pm 11 April 2024 - Status changed to Fixed
about 1 year ago 12:22pm 11 April 2024 - 🇩🇪Germany Grevil
Here is the follow up issue: 📌 Instead of passing a context in "HomeboxForm", divide the Form into two seperate forms Active .
Automatically closed - issue fixed for 2 weeks with no activity.