Contrib.social

Do not show technical errors / exceptions to users

Open on Drupal.org →
Created on 8 April 2024, about 1 year ago
Updated 23 April 2024, 12 months ago

Problem/Motivation

This is a follow-up on 🐛 Login leads to Exeception, if the contract does not exist Fixed .

In that issue, we reduced the effect of errors in hook events like user login / creation, ...

As a result, users logging in, but having no connected Billwerk account, leads to user facing technical messages like:

GuzzleHttp\Exception\ClientException: Client error: `GET https://sandbox.billwerk.com/api/v1/contracts/123123` resulted in a `404 Not Found` response: {"Message":"Contract with Id '123123123' does not exist."}

Which is not helpful for users or may even lead to information disclusoure.

So we should just log these messages but not show them.
If it's needed to indicate that an error happened, we could only expose certain Exception types later or show a general text.

For now we'll just NOT show these messages.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024