- Issue created by @Extatic
- 🇺🇦Ukraine Extatic
The proposed patch is designed to use library as internal dependency.
- 🇪🇸Spain gxleano Cáceres
Hi @Extatic
You already have two ways to get the library:
1. Via CDN (Default)
2. Serving the script locally - Status changed to Closed: won't fix
8 months ago 2:49pm 8 April 2024 - Status changed to Active
6 months ago 8:22am 17 June 2024 - 🇩🇪Germany drubb Sindelfingen
Reopening this ticket, as there's still an issue related to the local fallback for libraries.
I've installed yaireo/tagify in the /libraries folder as suggested. Looking at my browser's devtools
I noticed most library files being fetched locally now, with one exception: tagify.min.js still fetched
from the CDN (Cloudflare):
I've taken a look at the library's source code on GitHub. Seems tagify.min.js has been removed
in release 4.25.0 in favor of an already minified tagify.js.
So the script can't be found locally and is still fetched from the CDN. Don't know why Cloudflare
delivers this non-existent file.
Switching from tagify.min.js to tagify.js should solve the issue. - Issue was unassigned.
- Status changed to Needs work
6 months ago 12:22pm 17 June 2024 - 🇩🇰Denmark ressa Copenhagen
Thanks for clearing that up @drubb, the file name needs to get updated then, so changing Status.
- Present in 4.24:
https://github.com/yairEO/tagify/blob/v4.24.0/dist/tagify.min.js - Removed in 4.25:
https://github.com/yairEO/tagify/blob/v4.25.0/dist/tagify.min.js
- Present in 4.24:
- last update
5 months ago Patch Failed to Apply - last update
5 months ago Patch Failed to Apply - last update
5 months ago Patch Failed to Apply - Status changed to Needs review
5 months ago 12:39pm 23 June 2024 - Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 8last update
5 months ago Not currently mergeable. - Merge request !99Issue #3439417 by gxleano: Fix Tagify library downloaded with composer → (Merged) created by gxleano
- last update
5 months ago 7 pass - last update
5 months ago 7 pass - Status changed to RTBC
5 months ago 3:49pm 29 June 2024 - 🇩🇪Germany drubb Sindelfingen
MR !99 works for me, all files are loaded locally:
Not sure how library versions should be handled. I don't like pinning stuff, so tested with Tagify 4.26.6, despite
the query parm saying 4.26.0Setting to RTBC.
- Status changed to Fixed
4 months ago 12:54pm 28 July 2024 - Status changed to Fixed
4 months ago 1:25pm 28 July 2024