- Issue created by @Balu Ertl
- Merge request !40Resolve #3438844 β Add 'audio' and 'generic' media types β (Merged) created by Balu Ertl
- Issue was unassigned.
- Status changed to Needs work
8 months ago 9:21pm 25 April 2024 - πΊπΈUnited States agentrickard Georgia (US)
The patch/MR is malformed and has non utf-8 characters, likely "smart" quotes.
+ 'children' => [ + '#markup' => t('Displaying media items of %bundle_name type by referencing their asset via an embed code is not supported by the remote DAM system. Therefore the Γ’β¬ΕManaged File IDΓ’β¬Β field has been already set to use instead.', [ + '%bundle_name' => \Drupal::entityTypeManager()->getStorage('media_type')->load($form['#bundle'])->label(), + ]), + ],
- First commit to issue fork.
- Status changed to Needs review
8 months ago 6:49pm 2 May 2024 - Assigned to Balu Ertl
- ππΊHungary Balu Ertl Budapest πͺπΊ
As we agreed that all open MRs should target the default
1.0.x
branch, I have spent half an hour with trying to manually backport this MR by cherrypicking each commit.However, it seems to be a tedious and risky task: there are examples both in the GUI and also in tests showing that this changeset definitely relies on the on-site asset syncing feature.
Therefore I would suggest making an exception with this one and letting it be merged into
1.1.x
branch first. After that, if we still think it is worth backporting to the older release, then it will be easier to do so by removing the parts related to on-site syncing. - ππΊHungary Balu Ertl Budapest πͺπΊ
MR updated with latest target branch, tests fixed, pipeline is green, ready for being RTBC'd.
-
japerry β
committed 0a04f330 on 1.1.x authored by
baluertl β
Issue #3438844: Allow audio and generic assets to be synced from...
-
japerry β
committed 0a04f330 on 1.1.x authored by
baluertl β
- πΊπΈUnited States japerry KVUO
Marking fixed so we can get it into the beta, but the embed codes should be added for these types. I'll open a new ticket to fix that part of the issue.
-
japerry β
committed 0a04f330 on acms-3567-asset-importer authored by
baluertl β
Issue #3438844: Allow audio and generic assets to be synced from...
-
japerry β
committed 0a04f330 on acms-3567-asset-importer authored by
baluertl β
- ππΊHungary Balu Ertl Budapest πͺπΊ
β[β¦] but the embed codes should be added for these types.β
Here we go: π Generalize embed codes of audio and generic asset types Active
Automatically closed - issue fixed for 2 weeks with no activity.