Allow audio and generic assets to be synced from acquia_dam

Created on 5 April 2024, 9 months ago
Updated 5 September 2024, 4 months ago

Allow β€œaudio” and β€œgeneric” media types too.

πŸ“Œ Task
Status

Needs review

Version

1.1

Component

Code

Created by

πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Balu Ertl
  • Pipeline finished with Failed
    9 months ago
    Total: 2571s
    #138451
  • Pipeline finished with Failed
    9 months ago
    Total: 3418s
    #138455
  • Pipeline finished with Failed
    9 months ago
    Total: 3215s
    #144757
  • Pipeline finished with Failed
    9 months ago
    Total: 3089s
    #144805
  • Pipeline finished with Failed
    9 months ago
    Total: 3208s
    #144823
  • Issue was unassigned.
  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί
  • Pipeline finished with Failed
    9 months ago
    Total: 2944s
    #144870
  • Status changed to Needs work 8 months ago
  • πŸ‡ΊπŸ‡ΈUnited States agentrickard Georgia (US)

    The patch/MR is malformed and has non utf-8 characters, likely "smart" quotes.

    +      'children' => [
    +        '#markup' => t('Displaying media items of %bundle_name type by referencing their asset via an embed code is not supported by the remote DAM system. Therefore the Ò€œManaged File IDÒ€ field has been already set to use instead.', [
    +          '%bundle_name' => \Drupal::entityTypeManager()->getStorage('media_type')->load($form['#bundle'])->label(),
    +        ]),
    +      ],
    
  • First commit to issue fork.
  • Status changed to Needs review 8 months ago
  • πŸ‡ΊπŸ‡ΈUnited States japerry KVUO
  • Pipeline finished with Failed
    8 months ago
    Total: 3703s
    #162813
  • Pipeline finished with Failed
    8 months ago
    Total: 3442s
    #162814
  • Pipeline finished with Failed
    8 months ago
    Total: 3179s
    #163703
  • Pipeline finished with Failed
    8 months ago
    Total: 3006s
    #163793
  • Assigned to Balu Ertl
  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί
  • Pipeline finished with Failed
    5 months ago
    Total: 1206s
    #237253
  • Pipeline finished with Failed
    5 months ago
    Total: 998s
    #237290
  • Pipeline finished with Failed
    5 months ago
    Total: 1144s
    #237316
  • Pipeline finished with Failed
    5 months ago
    Total: 4041s
    #237389
  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί

    As we agreed that all open MRs should target the default 1.0.x branch, I have spent half an hour with trying to manually backport this MR by cherrypicking each commit.

    However, it seems to be a tedious and risky task: there are examples both in the GUI and also in tests showing that this changeset definitely relies on the on-site asset syncing feature.

    Therefore I would suggest making an exception with this one and letting it be merged into 1.1.x branch first. After that, if we still think it is worth backporting to the older release, then it will be easier to do so by removing the parts related to on-site syncing.

  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί

    MR updated with latest target branch, tests fixed, pipeline is green, ready for being RTBC'd.

  • Pipeline finished with Skipped
    3 months ago
    #297593
  • πŸ‡ΊπŸ‡ΈUnited States japerry KVUO

    Marking fixed so we can get it into the beta, but the embed codes should be added for these types. I'll open a new ticket to fix that part of the issue.

  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί

    β€œ[…] but the embed codes should be added for these types.”

    Here we go: πŸ“Œ Generalize embed codes of audio and generic asset types Active

  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024