- Issue created by @Anybody
- Assigned to sarwan_verma
- Issue was unassigned.
- Status changed to Needs review
9 months ago 5:19am 5 April 2024 - last update
9 months ago 31 pass, 2 fail - 🇮🇳India sarwan_verma
Hi@Anybody,
I have fixed this "strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated Captcha.php:104" and also attached patch,
kindly review and verify , The last submitted patch, 3: captcha-3438259.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- 🇩🇪Germany Anybody Porta Westfalica
@sarwan_verma please use !empty() instead and use a MR instead of a patch.
- last update
9 months ago 31 pass, 2 fail - Status changed to Needs review
9 months ago 5:53am 5 April 2024 - Status changed to Needs work
9 months ago 6:09am 5 April 2024 - 🇩🇪Germany Anybody Porta Westfalica
FALSE must be uppercase. Code style errors. Please configure your tooling correctly for Drupal!
- last update
9 months ago 31 pass, 2 fail - Status changed to Needs review
9 months ago 6:48am 5 April 2024 - 🇩🇪Germany Anybody Porta Westfalica
What I'm wondering about now is, that your changes don't target Captcha.php:104?
Were you able to reproduce the notice?
- First commit to issue fork.
-
japerry →
committed b677c224 on 2.x authored by
sarwan_verma →
Issue #3438259: strpos(): Passing null to parameter #1 ($haystack) of...
-
japerry →
committed b677c224 on 2.x authored by
sarwan_verma →
- Status changed to Fixed
6 months ago 5:24am 2 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.