After adding the GitLab CI template, some phpstan issues are identified:
------ ----------------------------------------------------------------------
Line src/JsonapiParse.php
------ ----------------------------------------------------------------------
260 \Drupal calls should be avoided in classes, use dependency injection
instead
------ ----------------------------------------------------------------------
------ ---------------------------------------------------------------------
Line tests/src/Functional/LoadTest.php
------ ---------------------------------------------------------------------
13 Drupal\Tests\BrowserTestBase::$defaultTheme is required. See
https://www.drupal.org/node/3083055, which includes recommendations
on which theme to use.
20 Property Drupal\Tests\jsonapi_include\Functional\LoadTest::$modules
property must be protected.
💡 Change record: https://www.drupal.org/node/2909426
32 Return type mixed of method
Drupal\Tests\jsonapi_include\Functional\LoadTest::setUp() is not
covariant with return type void of method
Drupal\Tests\BrowserTestBase::setUp().
------ ---------------------------------------------------------------------
[ERROR] Found 4 errors
The last issue is already fixed here 🐛 Unit test fails because of return type RTBC , so this issue will be dependent on that one.
Fixed
1.0
Code
Issue #3438021 by ptmkenny: Fix phpstan issues
Automatically closed - issue fixed for 2 weeks with no activity.