- Issue created by @baldwinlouie
- Status changed to Needs review
9 months ago 8:33pm 3 April 2024 - πΊπΈUnited States baldwinlouie
@yas, please review this patch. This fix moves the Cancel button into the correct location in a modal. It turns out the following code removes the necessary css class that the Dialog JS needs to move the button into the lower right hand corner.
$form['actions']['cancel']['#attributes']['class']['0'] = '';
I also changed the color of the Cancel button. Best practice says the the cancel button should be a different color than the main "Delete" button. That way, the user can easily distinguish between the two.
What do you think about the color change.
- Status changed to RTBC
9 months ago 9:11pm 3 April 2024 - πΊπΈUnited States yas California πΊπΈ
@baldwinlouie
Thank you for the fix. I tried the patch and it looks perfect. I'll merge the patch to
6.x
and7.x
; and close this issue as Fixed. -
yas β
committed 7df16979 on 7.x authored by
baldwinlouie β
Issue #3437940 by baldwinlouie, yas: Fix the 'Cancel' button placement...
-
yas β
committed 7df16979 on 7.x authored by
baldwinlouie β
-
yas β
committed 65f0dd13 on 6.x authored by
baldwinlouie β
Issue #3437940 by baldwinlouie, yas: Fix the 'Cancel' button placement...
-
yas β
committed 65f0dd13 on 6.x authored by
baldwinlouie β
- Status changed to Fixed
9 months ago 9:13pm 3 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.