Role hiding assumption is too optimistik

Created on 3 April 2024, over 1 year ago

Problem/Motivation

JS toggle implementation assumes the two first roles are always anonymous and registered user, but roles are sortable and I just ran into a case where the assumption is wrong, so that "Authenticated user" role (and thereby all other roles) are hidden!

toggle: function toggle() {
      var isAuthChecked = $('#edit-roles-authenticated').is(':checked');
      // Removing first 2 options, as they will always be Anon and Auth roles.
      $('.js-form-item.js-form-type-checkbox').slice(2).each(function () {
        this.style.display = isAuthChecked ? 'none' : '';
      });
    }

Steps to reproduce

Proposed resolution

Exclude the "anonymous" and "authenticated" user role by key

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @Anybody
Comment about 2 months ago →
🇺🇸United States tyler.hastain Utah
I am running into this problem as well. I only want one role to be able to access these. So I just moved that role to be in the second position.
Comment about 2 months ago →
🇮🇳India vinodhini.e chennai
vinodhini.e → made their first commit to this issue’s fork.
Comment 23 days ago →
🇪🇸Spain willeaton
What I am finding is that it does the complete opposite, i ONLY see anonymous and authenticated and I understand that this code is supposed to only hide those two options... not sure why its done via JS and not in the form...

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024