- Issue created by @carolpettirossi
- First commit to issue fork.
- 🇺🇦Ukraine olegrymar
olegrymar → changed the visibility of the branch 3437650-cta-button-overlaps to hidden.
- Status changed to Needs review
9 months ago 3:41pm 2 April 2024 - 🇧🇷Brazil carolpettirossi Campinas - SP
carolpettirossi → changed the visibility of the branch 3437650-cta-button-overlaps to active.
- 🇧🇷Brazil carolpettirossi Campinas - SP
The MR did solve the issue on our project.
After patch:
However not sure why the cards have a inline height set that led us to add a !important to code
- 🇺🇸United States froboy Chicago, IL
@carolpettirossi @olegrymar I disagree with this approach. It took a minute to dig up, but the inline heights are being set by the legacy jQuery MatchHeight functionality in openy_carnation:
After going into that page and removing the card styles from the MatchHeight configuration, the cards now resize correctly.
Please review and if you agree we can mark this "Closed, works as designed."
- 🇧🇷Brazil carolpettirossi Campinas - SP
@froboy,
That does solve the issue with the buttons over the border.
However, I would expect the buttons to be aligned at the bottom of the card. And they are now right after the text.
- Merge request !47fix: [#3437650] set 100% height on cards to align heights → (Merged) created by froboy
- 🇺🇸United States froboy Chicago, IL
As seen here, this new MR supports varying heights on cards with either button position.
- 🇧🇷Brazil carolpettirossi Campinas - SP
MR #47 worked like a charm. I had also removed the following from /admin/appearance/settings/openy_carnation
.card .card-body .card h3 .card .node__contentResult:
- Status changed to RTBC
8 months ago 3:26pm 15 April 2024 - Status changed to Fixed
8 months ago 5:14pm 15 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.