Fix coding standards

Created on 30 March 2024, 3 months ago

Problem/Motivation

The Gitlab CI pipeline identified several coding standards issues: https://git.drupalcode.org/issue/jsonapi_links-3437151/-/jobs/1197339

Let's fix these.

πŸ“Œ Task
Status

Needs review

Version

1.0

Component

Code

Created by

πŸ‡―πŸ‡΅Japan ptmkenny

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ptmkenny
  • Merge request !8Fixes for coding standards β†’ (Open) created by ptmkenny
  • Status changed to Needs review 3 months ago
  • πŸ‡―πŸ‡΅Japan ptmkenny

    This fixes all of the coding standards issues identified except 2:

    ---------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    ---------------------------------------------------------------------------------------------
     33 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     39 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
    ---------------------------------------------------------------------------------------------
    

    I think dependency injection can be a separate issue than other coding standard fixes because DI can sometimes cause problems, so it should be a separate commit.

Production build 0.69.0 2024