- Issue created by @Grimreaper
- Merge request !26Issue #3437139: LinksSettingType: add attributes of the link generator → (Merged) created by Grimreaper
- Issue was unassigned.
- Status changed to Needs review
8 months ago 2:24pm 30 March 2024 - 🇫🇷France pdureau Paris
UI Patterns 2.x port will be done here: ✨ [2.0.x-alpha2] LinksSettingType: add attributes of the link generator Active
- 🇫🇷France Grimreaper France 🇫🇷
Need to test potential impact on pagination and breadcrumb.
- Assigned to Grimreaper
- Issue was unassigned.
- 🇫🇷France Grimreaper France 🇫🇷
No impact on breadcrumb and pagination.
The places set_active_class is used in core are:
- menu: which we want https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...
- book: which we want for the book menu https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/book/...
- language block: to pass to links template https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/langu...
- links theme key: should not have impact https://git.drupalcode.org/project/drupal/-/blob/11.x/core/includes/them...
- menu local task: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/includes/them..., not used in UI Suite Bootstrap, but maybe a normalize should be applied in https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/5.0.x/src/H... and pattern should be reworked?
- menu local action: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/includes/them..., bypased in UI Suite Bootstrap https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/5.0.x/src/H... - Assigned to Grimreaper
- Issue was unassigned.
-
Christian.wiedemann →
committed 309e84d4 on 8.x-2.x authored by
Grimreaper →
Issue #3437139 by Grimreaper: LinksSettingType: add attributes of the...
-
Christian.wiedemann →
committed 309e84d4 on 8.x-2.x authored by
Grimreaper →
- Status changed to Fixed
6 months ago 2:25pm 5 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.