- Issue created by @longwave
- Status changed to Needs review
5 months ago 9:23pm 1 April 2024 - Status changed to Needs work
5 months ago 1:51pm 2 April 2024 - πΊπΈUnited States smustgrave
Since this will require sites to update their settings.php should a CR be included.
- π¬π§United Kingdom longwave UK
Unsure if we can use the existing change record given we only just introduced this, or if we should have a separate one: https://www.drupal.org/node/3177901 β
That CR also says Drupal 12+ but this issue says 11...
- πΊπΈUnited States smustgrave
So that CR/ticket was only committed for 10.3, which isn't released yet. So imagine updating the CR to more mention this setting is only for D10.3+ and automatic in D11. Thoughts?
- π¬π§United Kingdom longwave UK
I think let's update the existing change record to mention Drupal 11 instead of 12 and say what to do when Drupal 11 is released.
- π³πΏNew Zealand quietone New Zealand
I agree that the existing change record should be updated as needed. However, there should be 2 changes records; one for the change that happens in 10.3.0 and one for the change that happens only in 11. They are distinct events. So, there should have a CR for each.
- πΊπΈUnited States smustgrave
Updated existing CR [#3177901]
Created new CR [#3443018]
But should $this->cacheLoaded = TRUE; be added tocore/lib/Drupal/Core/State/State.php
- Status changed to RTBC
5 months ago 4:56pm 25 April 2024 - πΊπΈUnited States smustgrave
Updated the CR and tests were green before. I just rebased.
- Status changed to Fixed
5 months ago 7:38pm 25 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.