Test failure on Drupal core 10.1+

Tests passing now. This also addresses some issues identified by phpstan.

The actual PHPunit test failures were fixed by updating the readMultiple() and getAllCollectionNames() methods on the ConfigSnapshotStorage class.

ConfigSnapshotStorage::readMultiple() was returning keys with empty values and was updated to work more like FileStorage::readMultiple().

ConfigSnapshotStorage::getAllCollectionNames() was using various array manipulation methods in kind of a confusing way and was updated to work more like MemoryStorage::getAllCollectionNames().

PHPstan issues addressed:

 ------ -------------------------------------------------------------------- 
  Line   src/Entity/ConfigSnapshot.php                                       
 ------ -------------------------------------------------------------------- 
  167    Method Drupal\config_snapshot\Entity\ConfigSnapshot::save() should  
         return int but return statement is missing.                         
 ------ -------------------------------------------------------------------- 
 ------ ------------------------------------------------------- 
  Line   tests/src/Unit/ConfigSnapshotConfigEntityUnitTest.php  
 ------ ------------------------------------------------------- 
  55     Missing call to parent::setUp() method.                
 ------ ------------------------------------------------------- 

Created a second MR (MR !5) that just includes a change to the ConfigSnapshotStorage class which seems to fix the failing test on its own.

joegraduate → changed the visibility of the branch 3436884-test-failure-on to hidden.

Thanks @joegraduate!

It looked like MR !4 might potentially have had an issue with configuration items that were also falsy. This seems resolved in MR !5 with the strict check. It seems reasonable that the PHPStan issues can be addressed separately from the test failure.

I tested out MR !5 and the snapshot storage still seems to work as expected. !5 looks good to me.

Thanks @tadean! Merged MR !5.

Automatically closed - issue fixed for 2 weeks with no activity.