- Issue created by @jonathan1055
- Merge request !66Issue #3436424: Remove cspell:disable-next-line for Lorem Ipsum text β (Merged) created by jonathan1055
- π¬π§United Kingdom jonathan1055
First commit removes the
cspell:disable-next-line
from seven files that have the "Lorem ipsum" lines. The cspell job fails as expected.
https://git.drupalcode.org/issue/ui_suite_uswds-3436424/-/pipelines/130459CSpell: Files checked: 316, Issues found: 316 in 7 files The number of unrecognised/misspelled words is 67
- π¬π§United Kingdom jonathan1055
Now a pipeline using gitlab_templates MR165
https://git.drupalcode.org/issue/ui_suite_uswds-3436424/-/pipelines/130466Interestingly this does not pass as expected. All of the words are OK except oe
CSpell: Files checked: 316, Issues found: 5 in 3 files
The number of unrecognised/misspelled words is 1
=== This is _cspell_unrecognized_words.txt ===
consectetuer
The suggestion for replacement is "consectetur" which is obviously the word in the lorum-ipsum dictionary. This word is already used in one of your files 3.0.x/templates/patterns/tooltip/tooltip.ui_patterns.yml#L34. - Status changed to Needs review
about 1 year ago 11:51am 27 March 2024 - π¬π§United Kingdom jonathan1055
I fixed the spelling in the three files, I guess it was a copy/paste from one original that was wrong somehow. The job passes green.
https://git.drupalcode.org/issue/ui_suite_uswds-3436424/-/pipelines/130484When the gitlab_templates MR has been merged and then rolled out to all contrib on the 'default-ref' branch then this MR can be committed. The temporary change to .gitlab-ci.yml here will need to be removed before merging.
-
smustgrave β
committed 7bd5a067 on 3.0.x authored by
jonathan1055 β
Issue #3436424: Remove cspell:disable-next-line for Lorem Ipsum text
-
smustgrave β
committed 7bd5a067 on 3.0.x authored by
jonathan1055 β
- Status changed to Fixed
about 1 year ago 5:03pm 1 April 2024 - π¬π§United Kingdom jonathan1055
Just be aware that with the above commit you are now using a gitlab_templates version which is currently slight ahead of the 'default-ref' but is also static. In due course you will want to revert just the .gilab-ci.yml change to put back
- project: $_GITLAB_TEMPLATES_REPO ref: $_GITLAB_TEMPLATES_REF
which will use the recommended 'default-ref', and delete the two $_CURL variables. There is no hurry, as the MR still exists and will be usable, but you will not be getting any of the newer work when 'default-ref' gets updated.
When #3436206: Add lorem-ipsum spelling dictionary β is merged you will see the commit listed in this link: compare/default-ref...main?from_project_id=96292
This shows all commits that are in 'main' but not yet reached 'default-ref'. If the commit is showing here then you need to wait.You can also see all the commits and where the tags are. This currently shows three commits which are above the set of tags, meaning that these are only in 'main' and have not yet reached 'default-ref'
Automatically closed - issue fixed for 2 weeks with no activity.
- π¬π§United Kingdom jonathan1055
Added π Set gitlab templates project and ref back to default Active to return to the default template