Created on 27 March 2024, 9 months ago

Problem/Motivation

config_inspector complains (also after saving the settings form):

options.showHideOpacity 	Undefined 	undefined 	No 	false 	missing schema 	'showHideOpacity' is not a supported key.
	options.maxSpreadZoom 	Undefined 	undefined 	No 	2 	missing schema 	'maxSpreadZoom' is not a supported key.
	options.closeOnScroll 	Undefined 	undefined 	No 	true 	missing schema 	'closeOnScroll' is not a supported key.
	options.mouseUsed 	Undefined 	undefined 	No 	false 	missing schema 	'mouseUsed' is not a supported key.
	options.history 	Undefined 	undefined 	No 	true 	missing schema 	'history' is not a supported key.
	options.focus 	Undefined 	undefined 	No 	true 	missing schema 	'focus' is not a supported key.
	maxZoomLevel 	Undefined 	undefined 	No 	<empty> 	missing schema 	'maxZoomLevel' is not a supported key.

All other keys are fine!

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Closed: cannot reproduce

Version

5.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Anybody
  • Issue was unassigned.
  • Status changed to Postponed: needs info 9 months ago
  • πŸ‡©πŸ‡ͺGermany Grevil

    Which version are you using? Photoswipe 5.x or 4.x? Have you run "drush updb" after upgrade to 5.x? These configs shouldn't exist anymore and they should have been cleared through photoswipe_update_9003.

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    @Grevil: We're using 5.0.0.
    Thanks, I'll try a manual fix and resave the form to see that happens.

  • Assigned to Grevil
  • Status changed to Active 9 months ago
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    @Grevil: I think I found the reason. Seems the update hook is incorrect:

    Most of these options are below "options" key!

    langcode: de
    photoswipe_always_load_non_admin: false
    enable_cdn: false
    options:
      showAnimationDuration: 333
      hideAnimationDuration: 333
      zoomAnimationDuration: 333
      maxWidthToAnimate: 4000
      easing: 'cubic-bezier(.4,0,.22,1)'
      bgOpacity: 1.0
      spacing: 0.12
      initialZoomLevel: fit
      secondaryZoomLevel: '2.5'
      maxZoomLevel: '4'
      allowPanToNext: true
      loop: true
      wheelToZoom: false
      pinchToClose: true
      clickToCloseNonZoomable: true
      closeOnVerticalDrag: true
      trapFocus: true
      returnFocus: true
      escKey: true
      arrowKeys: true
      imageClickAction: zoom-or-close
      tapAction: toggle-controls
      doubleTapAction: zoom
      bgClickAction: close
      closeTitle: Schließen
      zoomTitle: Zoom
      arrowPrevTitle: Vorherige
      arrowNextTitle: Weiter
      indexIndicatorSep: ' / '
      errorMsg: 'Das Bild konnte nicht geladen werden.'
      preload:
        - 1
        - 1
      preloaderDelay: 2000
      mainClass: ''
      showHideOpacity: false
      maxSpreadZoom: 2
      closeOnScroll: true
      mouseUsed: false
      history: true
      focus: true
    maxZoomLevel: null
    

    And maxZoomLevel was only set to a value, not deleted. It's existing twice in the config.

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    PS: Of course this can be a local bug, but I don't think so, because I should have noticed a possible error.

    To reproduce this, perhaps install a version before that update hook first and then update?
    Then you should see the results.

  • Status changed to Closed: cannot reproduce 9 months ago
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Okay I think it was a local issue. I deleted the old config and resaved the settings, now it looks fine.

    Let's close this until someone reports the same.

Production build 0.71.5 2024