Make this module compatible with Group 2.x as well

Created on 26 March 2024, 8 months ago
Updated 7 May 2024, 7 months ago

Problem/Motivation

It is a big challenge for some site to go to group 3.x and they already have unsupported warning with this module so going to group 2.x is the easier way. And group_notify do not support that version at least there few issues about that.

Steps to reproduce

In your site which already have installed the module group and group_notify update group to 2.x and group_notify to 2.0.0-beta1, then you will see error about unfound entity type 'group_relationship'.

Proposed resolution

In seems the only issue in this module is about the entity_type_id we provide to services, currently the module use 'group_relationship' for the version 3 need. We can make it generic the module check the version of group and give the entity_type_id.

Remaining tasks

Make a patch or MR.

User interface changes

NA

API changes

NA

Data model changes

NA

✨ Feature request
Status

RTBC

Version

2.0

Component

Code

Created by

πŸ‡ΈπŸ‡³Senegal diaodiallo

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @diaodiallo
  • Status changed to Needs review 8 months ago
  • πŸ‡ΈπŸ‡³Senegal diaodiallo

    Here is a patch to support both versions.

  • πŸ‡¨πŸ‡¦Canada phjou Vancouver πŸ‡¨πŸ‡¦ πŸ‡ͺπŸ‡Ί

    The requirement in the info file also makes it impossible to use:
    dependencies:
    - group:gnode (>=3.2.0)

    I am not sure why that has been added but it seems to restrictive. Version 2 is still supported by group.

  • πŸ‡¨πŸ‡¦Canada phjou Vancouver πŸ‡¨πŸ‡¦ πŸ‡ͺπŸ‡Ί

    New patch removing the hard requirement in the info file.

    But the legitimate question is should we have 2 different branches like the Group module?

  • πŸ‡¨πŸ‡¦Canada phjou Vancouver πŸ‡¨πŸ‡¦ πŸ‡ͺπŸ‡Ί

    That's the patch for the beta1 if people need it since the release add some lines at the bottom of the info file that are not in the repo.

  • πŸ‡¨πŸ‡¦Canada phjou Vancouver πŸ‡¨πŸ‡¦ πŸ‡ͺπŸ‡Ί

    That's the patch for the beta1 if people need it since the release add some lines at the bottom of the info file that are not in the repo.

  • πŸ‡¨πŸ‡¦Canada phjou Vancouver πŸ‡¨πŸ‡¦ πŸ‡ͺπŸ‡Ί
  • πŸ‡ΈπŸ‡³Senegal diaodiallo

    Thank you @phjou for your patches, I will check it and let you know.

  • Status changed to RTBC 7 months ago
  • πŸ‡ΈπŸ‡³Senegal diaodiallo

    I reviewed the patch group-notify-beta1-3436167.patch. I think can go to RTBC.

Production build 0.71.5 2024