- Issue created by @KeyboardCowboy
- πΊπΈUnited States KeyboardCowboy Denver, CO, USA
We need to get the design mocks for this one from Figma.
- Assigned to kostyashupenko
- Issue was unassigned.
- Status changed to Postponed
8 months ago 7:07am 27 March 2024 - π·πΊRussia kostyashupenko Omsk
Postponed because this functionality is already partially done here https://www.drupal.org/project/navigation/issues/3427659 π Implement drawer functionality Needs review
- Status changed to Active
8 months ago 3:30pm 1 April 2024 - πͺπΈSpain ckrina Barcelona
This has bee implemented in π Implement drawer functionality Needs review and π Implement the new designs to the drawer Needs review . But one small detail is missing: the pointer style should be defined so the browser doesn't show a "?".
- Merge request !235Issue #3435989:Adjust block title styles for collapsed state according designs β (Merged) created by ckrina
- Status changed to Needs review
8 months ago 12:28pm 6 April 2024 - πͺπΈSpain ckrina Barcelona
Added styles based on the final designs, plus updated the issue summary to reflect the final designs and testing steps.
- π©πͺGermany rkoller NΓΌrnberg, Germany
One problem to note, if you try to tab through the collapsed sidebar, menu block titles are not focusable. with tabbing that structuring element is unavailable to screenreader users. the only cue screenreader users have is that there are four headers by default (in case the display of title is active):
shortcuts
content
administration
rkollerjust based on the announcement it is not clear that those are actual section headers, you would need the visual context. in addition tabbing is the only way to get all the menu block titles as well as menu items in consecutive order. in the voice over rotor the components are scattered, the block titles are headers, top level items with a sub menu are buttons and top level items without a submenu are links.
- πͺπΈSpain ckrina Barcelona
@rkoller thanks for the feedback! Could you open a follow-up issue for that and add it into the accessibility plan? It's not that I don't care about accessibility, but we need to move and iterate fast to get the navigation to a better point, and the classic core treatment of issues where nothing gets in until it's perfect will slow us down in this very key moment. :)
- πͺπΈSpain ckrina Barcelona
@rkoller opened π Improve how and what navigation block titles are communicating to screenreader users Active as a follow-up for the keyboard issue.
- Status changed to RTBC
8 months ago 4:05pm 9 April 2024 - π©πͺGermany rkoller NΓΌrnberg, Germany
There are only two concerns i have. For the first i've already opened up a follow up issue in the context of keyboard and screenreader accessibility (will add another comment about the needs for sighted keyboard users there as well).
the other detail is about the dot, but that concern shouldnt be a blocker for this issue. overall it is difficult to communicate with just an icon that the user should hover over the icon (when i first saw the dot i thought some icon was missing - like for a missing unicode glyph) . creating another follow up issue wouldnt make much sense since that issue wouldnt be actionable and with the navigation issue queue moving over into the core issue cue soon it would be cruft for the time being. @ckrina made a note about the dot and will continue ideating on it over with the folks in the design team. therefore no followup issue necessary in this case. therefore this issue could be set to rtbc -
ckrina β
committed b18e344f on 1.x
Issue #3435989 by ckrina, rkoller: Add Collapsed Status for Menu Block...
-
ckrina β
committed b18e344f on 1.x
- Status changed to Fixed
8 months ago 4:31pm 9 April 2024 - πͺπΈSpain ckrina Barcelona
Thanks @rkoller! Merging this for now and we can make the improvements in a follow-up.
Automatically closed - issue fixed for 2 weeks with no activity.