- Issue created by @KeyboardCowboy
- Assigned to starshaped
- Assigned to bronzehedwick
- Merge request !204Sub menus open to side drawer on click #3427659 β (Merged) created by bronzehedwick
- First commit to issue fork.
- πͺπΈSpain ckrina Barcelona
Adding more definition and screenshots on the IS to define and limit the scope.
- First commit to issue fork.
- πΊπΈUnited States bronzehedwick New York
Okay, I pushed fixes for the above. Now:
- The mobile styles should work again
- The expanding nav should be in sync with the submenu animation
- The animations should be more performant
- The animation timing is abstracted to a variable
- Animations are disabled if user prefers-reduced-motion
- Lint errors are fixed
These aspects are ready for review.
TODO
There's an outstanding issue with
z-index
levels for the submenu drawer animation. The submenus should slide out from behind the navigation, and this works, except for the footer element, which is a sibling of the content nav. This causes the footer submenus to animate over the navigation.Would it be okay to move the footer nav inside the content nav, and achieve the same visual effect via CSS? I'm not sure if there are accessibility implications here. Screenshot of potential markup below.
- πΊπΈUnited States bronzehedwick New York
I pushed a fix for the footer submenu
z-index
issue, above, and should now be fixed.While fixing that issue, I noticed the mobile submenus don't have the correct size across screen sizes, so I'm looking into that now.
- πΊπΈUnited States bronzehedwick New York
I've pushed a fix for the mobile submenu size issue, above. All know issues have fixes applied. This issue is now ready for review.
- Issue was unassigned.
- Status changed to Needs review
8 months ago 4:53pm 27 March 2024 - Status changed to Needs work
8 months ago 5:36pm 27 March 2024 - π·πΈSerbia finnsky
I see few issues on mobile and desktop js behaviour. i would like to have them fixed aswell.
- πͺπΈSpain ckrina Barcelona
This is looking great! Almost there :D
I'm still seeing the error where, after opening one of the main parent items, it doesn't close when I hover another item:
- π©πͺGermany rkoller NΓΌrnberg, Germany
one detail i've noticed, if you open up a submenu you then have the label of the top level menu item as the "heading" now. That heading is clickable by the mouse but it has an invisible focus outline when you tab through the menu by keyboard (ref wcag sc 2.4.7 - focus visible).
- Status changed to Needs review
8 months ago 6:45pm 27 March 2024 - πΊπΈUnited States bronzehedwick New York
Confirming receipt. Working on the issues outlined.
- πΊπΈUnited States bronzehedwick New York
@ckrina Woops, I forgot to fix dismissing the submenu on hover out. Pushed a fix for that!
- Assigned to finnsky
- Status changed to Needs work
8 months ago 8:51pm 27 March 2024 - πͺπΈSpain ckrina Barcelona
Moving it back to Needs work because @finnsky is working on JS fixes.
- Status changed to Needs review
8 months ago 8:57pm 27 March 2024 - Issue was unassigned.
- Status changed to Needs work
8 months ago 8:24am 28 March 2024 - πͺπΈSpain ckrina Barcelona
As mentioned yesterday in Slack, I'm still seeing weird behaviors and I think it's related to the fact that the open/close is reacting to hovering something else, when the event to trigger that change should be related to the element itself youβre interacting with. For example, if I leave the user menu to click on the collapse button, that should close its child drawer. But doesn't:
Moving to Needs Work to draw attention to this, because if an event as key like this needs to be changed it's better to do it in this issue.
- Status changed to Needs review
8 months ago 9:08am 28 March 2024 -
ckrina β
committed 73924eec on 1.x authored by
bronzehedwick β
Sub menus open to side drawer on click #3427659
-
ckrina β
committed 73924eec on 1.x authored by
bronzehedwick β
- Status changed to Fixed
8 months ago 9:48am 28 March 2024 - πͺπΈSpain ckrina Barcelona
And merged! Thanks everybody involved, specially @bronzehedwick and @finnsky for the great work and collaboration with this time-sensitive key feature!
Automatically closed - issue fixed for 2 weeks with no activity.