- Issue created by @Noor Eldin Essam
- Issue was unassigned.
- 🇯🇴Jordan mahmoud barhouma
An error occurred after applying the patch
InvalidArgumentException: $string ("7057153") must be a string. in Drupal\Core\StringTranslation\TranslatableMarkup->__construct( - Status changed to Needs work
8 months ago 7:53am 25 March 2024 - 🇹🇼Taiwan g-brodiei
+++ b/src/Plugin/Block/VisitorsBlock.php @@ -265,7 +265,7 @@ final class VisitorsBlock extends BlockBase implements ContainerFactoryPluginInt + $item = $this->t('Total Visitors:') .$count; @@ -295,7 +295,7 @@ final class VisitorsBlock extends BlockBase implements ContainerFactoryPluginInt + $item = $this->t('Registered Users:') .$registered_users_count;
Thanks for the patch, works fine on 2.16, just some nit picks I see here, need to add space for concatenation.
- Status changed to Needs review
8 months ago 6:53am 5 April 2024 - 🇮🇳India immaculatexavier
As per #11 created patch by fixing the concatenation.
Kindly review - Status changed to Needs work
8 months ago 6:35am 12 April 2024 - 🇹🇼Taiwan g-brodiei
/** * Display last registered user to visitors block. */ protected function showLastRegisteredUser(): string { $last_user_uid = $this->database->select('users', 'u') ->fields('u', ['uid']) ->orderBy('uid', 'DESC') ->range(0, 1) ->execute() ->fetchField(); $user = $this->entityTypeManager->getStorage('user')->load($last_user_uid); $username = [ '#theme' => 'username', '#account' => $user, ]; $item = $this->t('Last Registered User:') . $this->renderer->render($username); return $item; }
#12 applies cleanly to 2.x-dev, but the render array of 'Last registered user' still escapes html element, setting back to NW, thanks!
- First commit to issue fork.
- @bluegeek9 opened merge request.
- Status changed to Fixed
7 months ago 8:37pm 29 April 2024 -
bluegeek9 →
committed e0ae228d on 8.x-2.x
Issue #3432630: Remove Not rendering HTML
-
bluegeek9 →
committed e0ae228d on 8.x-2.x
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇺🇸United States bluegeek9
This issue was resolved. A new release, 8.x-2.17, will be made soon, May 31st.
This is an excellent opportunity to beta test the dev branch, and report any issues.
Contributors (5)
bluegeek9 → , roshni27 → , abhishek_gupta1 → , sarwan_verma → , SandeepSingh199 →
Changelog
Issues: 32 issues resolved.
Changes since 8.x-2.16 → :
Bug
- #3432630 → : Remove Not rendering HTML
- #3395217 → by bluegeek9 → : On a fresh install of a Drupal site with this module included, we get dependency errors
- #3400985 → by bluegeek9 → : Site break when placed visitors module
- #3413155 → by abhishek_gupta1 → , bluegeek9 → : Give Default value to all $agent keys
- #3383142 → by bluegeek9 → : ParseError: syntax error, unexpected
- #3380760 → : Warning: Undefined array key
Feature
- #3376256 → : Page Performance Metrics
- #3378568 → : Ajax Replace Report
- #3376234 → : Route reports
- #3378580 → : Browser Report(s)
- #1087268 → by bluegeek9 → : Exclude robots from the statistics
- #3376233 → by bluegeek9 → : View filter date range
- #3369318 → : Log OS and device infomation - BrowserCap replacement
- #3376235 → by bluegeek9 → : Drush command: Download MaxMind database
- #3250285 → by bluegeek9 → : Performance: Add db indexes
Task
- #3389685 → : Three different errors displayed
- #3376397 → by bluegeek9 → , roshni27 → : Remove block settings from visitors.config
- #3376392 → : Move Visitors Report menu
- #3444385 → : Module path
- #3443031 → by bluegeek9 → : Issues reported by PHPCS
- #3392006 → by bluegeek9 → , sarwan_verma → : watchdog_exception() deprecated
- #3423013 → : Deprecated function user_role_names()
- #3423001 → by bluegeek9 → : composer.json missing "repositories"
- #3397326 → by bluegeek9 → , SandeepSingh199 → : Issues reported by PHPStan
- #3401384 → : Remove Drupal 9 from GitLab CI
- #3393046 → by bluegeek9 → : Code Coverage
- #3377961 → : Replace visitors/hosts reports with views
- #3377962 → : Replace visitors/hits with Views
- #3377964 → : Replace /visitors/pages with Views
- #3377960 → by bluegeek9 → : Log visitor local time
- #3376241 → : Drush Command: Rebuild Geo Location
- #3377958 → : Tracking cookies