- Issue created by @joshahubbers
- Status changed to Needs review
over 1 year ago 3:15pm 20 March 2024 - Open on Drupal.org βCore: 10.1.4 + Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Waiting for branch to pass - π³π±Netherlands joshahubbers
In Drupal < 10.2 the ByteSizeMarkup doesn't exsist. Version of the patch with the old format_size() function.
- Status changed to RTBC
over 1 year ago 8:08am 25 March 2024 The last submitted patch, 3: 3432428-webform-form_filesize_limit_message-3.patch, failed testing. View results β
45:20 43:46 RunningThe last submitted patch, 3: 3432428-webform-form_filesize_limit_message-3.patch, failed testing. View results β
- Status changed to Needs work
over 1 year ago 5:17am 9 April 2024 - πΊπΈUnited States jrockowitz Brooklyn, NY
Some tests are failing.
We might need to address this with the file_validate_size() deprecation.
- Merge request !728[#3432428] feat: Information message for file uploads is confusing when form limit is enabled β (Merged) created by jrockowitz
- πΊπΈUnited States jrockowitz Brooklyn, NY
I rerolled the patch to 6.3.x, and the updated test is passing. If all the test pass, I will probably do a minor refactor of the code to improve the clarity.
- πΊπΈUnited States jrockowitz Brooklyn, NY
It is worth noting that I moved things around and used PHPStorm's AI to simplify and clarify the code
-
jrockowitz β
committed c167ee6d on 6.3.x
[#3432428] feat: Information message for file uploads is confusing when...
-
jrockowitz β
committed c167ee6d on 6.3.x
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Fixed in this commit:
https://git.drupalcode.org/project/webform/-/commit/c167ee6dcfb79b5d54d1...
-
jrockowitz β
committed c167ee6d on 6.x
[#3432428] feat: Information message for file uploads is confusing when...
-
jrockowitz β
committed c167ee6d on 6.x