Contrib.social

Automated Drupal 11 compatibility fixes for menu_link_weight

Open on Drupal.org →
Created on 18 March 2024, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

2.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Comment about 1 year ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-121090

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !12Automated Project Update Bot fixes → (Open) created by project update bot
  • Comment about 1 year ago →
    project update bot

    This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-137198

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.10
    3. palantirnet/drupal-rector: 0.20.1
  • First commit to issue fork.
  • Merge request !15Drupal 11 fixes added. → (Open) created by Unnamed author
  • Comment 5 months ago →
    sarigaraghunath
  • Comment 5 months ago →
    sarigaraghunath

    MR15 is working fine in both d10 and d11.

  • Comment 5 months ago →
    🇮🇳India jradhak
  • Comment 5 months ago →
    🇮🇳India jradhak
  • Status changed to Needs work 3 months ago
  • Comment 3 months ago →
    🇨🇭Switzerland tcrawford

    This issue was created against 2.x and MR 15 does not apply against 2.x (only 1.x). MR 12 does not adapt the core version requirement. Therefore, I am placing this issue back to needs work. I suggest to create a separate issue for Drupal 11 compatibility for 1.x.

  • Merge request !16Issue #3431965: Drupal 11 compatibility (2.x). → (Merged) created by tcrawford
  • Comment 3 months ago →
    🇨🇭Switzerland tcrawford

    I created MR 16 (against 2.x) that also contains the changes to the info file. This needs a review.

  • Comment 3 months ago →
    System Message
  • Status changed to Downport 23 days ago
  • Comment 23 days ago →
    🇧🇬Bulgaria pfrenssen Sofia

    This is fixed for 2.x, but can still potentially be backported to the 1.x branch.

  • Comment 7 days ago →
    🇧🇪Belgium weseze

    Patch attached for 1.x.

  • First commit to issue fork.
  • Comment 7 days ago →
    🇯🇵Japan ultrabob Japan

    Thanks for the patch @weseze that helped me get going again. I've coalesced your patch with the existing changes in the MR against 1.x: https://git.drupalcode.org/project/menu_link_weight/-/merge_requests/15

    I also added gitlab-ci to it to give us some visibility into the state of the code. There are a ton of code quality issues that we should try to fix down the line, but in order to roll the new release, I'd like to get rid of the test failures.

    There are two failures about menu_link_weight not being compatible, which I don't understand:

    Unable to install modules: module 'menu_link_weight' is incompatible with this version of Drupal core.

    The complaint that the classy theme doesn't exist is more familiar:

    Drupal\Core\Extension\Exception\UnknownExtensionException: Unknown themes: classy.

    If someone can get these tests passing, and we can get this issue to RTBC, I'll be glad to roll a Drupal 11 release.

  • First commit to issue fork.
  • Pipeline finished with Failed
    1 day ago
    Total: 303s
    #497105
  • Pipeline finished with Failed
    1 day ago
    Total: 268s
    #497118
  • Comment 1 day ago →
    🇬🇧United Kingdom aurora-norris

    I've gotten rid of the error that menu_link_weight is incompatible with this Drupal version

  • Comment about 15 hours ago →
    🇯🇵Japan ultrabob Japan

    Thanks @aurora-norris! Now we are one error and one test failure away from release:

    1) Drupal\Tests\menu_link_weight\FunctionalJavascript\MenuLinkWeightNodeJavascriptTest::testMenuFunctionality
    Drupal\Core\Extension\Exception\UnknownExtensionException: Unknown themes: classy.
    /builds/issue/menu_link_weight-3431965/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:136
    /builds/issue/menu_link_weight-3431965/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
    /builds/issue/menu_link_weight-3431965/web/core/tests/Drupal/Tests/BrowserTestBase.php:554
    /builds/issue/menu_link_weight-3431965/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
    /builds/issue/menu_link_weight-3431965/tests/src/FunctionalJavascript/MenuLinkWeightJavascriptTestBase.php:72
    --
    There was 1 failure:
    1) Drupal\Tests\menu_link_weight\Functional\MenuLinkWeightNodeTest::testNodeForm
    Behat\Mink\Exception\ExpectationException: Link with label fd2g4uxp found.
    /builds/issue/menu_link_weight-3431965/web/core/tests/Drupal/Tests/WebAssert.php:591
    /builds/issue/menu_link_weight-3431965/web/core/tests/Drupal/Tests/WebAssert.php:357
    /builds/issue/menu_link_weight-3431965/tests/src/Functional/MenuLinkWeightNodeTest.php:38

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024