- Issue created by @Project Update Bot
- last update
8 months ago 9 pass, 4 fail This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-121090This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
- last update
8 months ago 9 pass, 4 fail - Status changed to Needs work
8 months ago 4:00pm 17 March 2024 The last submitted patch, 2: isbn.8.x-1.4.rector.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- First commit to issue fork.
- Merge request !12Marked module as D11 compatible and attempt to run tests on D11. → (Merged) created by megachriz
- last update
8 months ago 20 pass - 🇳🇱Netherlands megachriz
Alright, tests cannot run on Drupal 11 yet, because dev dependency Feeds is not marked Drupal 11 compatible yet. Makes sense. Luckily, I maintain Feeds.
I'll let this issue hang then for a while.
- Status changed to Needs review
8 months ago 5:33pm 4 April 2024 - last update
8 months ago 20 pass This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-137198These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.10
- palantirnet/drupal-rector: 0.20.1
- last update
8 months ago 20 pass - 🇪🇸Spain plopesc Valladolid
Would be great to have a new stable release for this module supporting D11.
Our sites are reporting Type Errors using 1.4 in Drupal 10.3.2.
Latest changes in dev release are fixing those errors, but having a stable release is always recommended.
Let me know if we could support you in any way to prepare the ground for the release.
Thank you
- 🇳🇱Netherlands megachriz
I plan to address this further after I'm done with the following projects:
- Feeds
- Feeds Extensible Parsers
- Tamper
- Feeds Tamper
- Feeds Textarea Fetcher
- Commerce Feeds
Feeds, Feeds Extensible Parsers and Feeds Tamper require:
- Review and commit of 🐛 [D11] InvalidQueryException when value for unique target is an array Needs review
- Manual testing on Drupal 11, especially error handling. For D11 compatibility,
watchdog_exception()
calls were replaced. I think that not every piece of code where that call was is covered by tests.
Tamper and Feeds Textarea Fetcher look ready.
Commerce Feeds waits on the next Feeds release.
For this module, ISBN Field, some manual testing on Drupal 11 would be good enough. Fixing CSpell and PHPStan errors is a nice to have.
-
megachriz →
committed c7dc56d2 on 8.x-1.x
Issue #3431115 by Project Update Bot, megachriz: Added Drupal 11...
-
megachriz →
committed c7dc56d2 on 8.x-1.x
- Status changed to Fixed
2 months ago 6:09pm 7 September 2024 - 🇳🇱Netherlands megachriz
All checks are green. I tested the ISBN-module manually as well on Drupal 11. All seems well.
- 🇳🇱Netherlands megachriz
@plopesc
I created a new release today 🙂
https://www.drupal.org/project/isbn/releases/8.x-1.5 → Automatically closed - issue fixed for 2 weeks with no activity.