- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-121090This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
- 🇮🇳India flutterstack
vendor/bin/drupal-check web/modules/custom/entity_delete_log/ --memory-limit=-1 Deprecated: The drupal_root parameter is deprecated. Remove it from your configuration. Drupal Root is discovered automatically. in /var/www/html/vendor/mglaman/phpstan-drupal/src/Drupal/DrupalAutoloader.php on line 94 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% ------ --------------------------------------------------------------------- Line entity_delete_log.module ------ --------------------------------------------------------------------- 73 Class User not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols ------ --------------------------------------------------------------------- [ERROR] Found 1 error Thanks for using drupal-check! Consider sponsoring the development of the maintainers which make drupal-check possible: - phpstan (ondrejmirtes): https://github.com/sponsors/ondrejmirtes - phpstan-deprecation-rules (ondrejmirtes)): https://github.com/sponsors/ondrejmirtes - phpstan-drupal (mglaman)): https://github.com/sponsors/mglaman - drupal-check (mglaman)): https://github.com/sponsors/mglaman
- 🇮🇳India flutterstack
#2 works fine.
In #6 I have applied #2 patch and fixed #5 drupacl check issue also. kindly review merge.
- 🇮🇳India flutterstack
static analysis on entity_delete_log throws below errors.
# php vendor/bin/drupal-check -a web/modules/custom/entity_delete_log --memory-limit=-1 Deprecated: The drupal_root parameter is deprecated. Remove it from your configuration. Drupal Root is discovered automatically. in /var/www/html/vendor/mglaman/phpstan-drupal/src/Drupal/DrupalAutoloader.php on line 94 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% ------ ------------------------------------------------------------------- Line entity_delete_log.install ------ ------------------------------------------------------------------- 13 Function entity_delete_log_schema() has no return type specified. 87 Function entity_delete_log_update_9001() has no return type specified. ------ ------------------------------------------------------------------- ------ ----------------------------------------------------------------------- Line entity_delete_log.module ------ ----------------------------------------------------------------------- 13 Function entity_delete_log_entity_predelete() has no return type specified. 43 Function entity_delete_log_entity_delete() has no return type specified. 144 Function _edl_get_configured_entity_types() has no return type specified. 152 Function _edl_get_failure_messages() has no return type specified. 152 Function _edl_get_failure_messages() has parameter $variables with no type specified. 175 Function _edl_log_entity_deletion() has no return type specified. 175 Function _edl_log_entity_deletion() has parameter $variables with no type specified. ------ ----------------------------------------------------------------------- ------ ----------------------------------------------------------------------- Line entity_delete_log.views.inc ------ ----------------------------------------------------------------------- 11 Function entity_delete_log_views_data() has no return type specified. ------ ----------------------------------------------------------------------- ------ -------------------------------------------------------------------------------------- Line src/Form/EntityDeleteLogSettingsForm.php ------ -------------------------------------------------------------------------------------- 58 Method Drupal\entity_delete_log\Form\EntityDeleteLogSettingsForm::create() has no return type specified. 76 Method Drupal\entity_delete_log\Form\EntityDeleteLogSettingsForm::getEditableConfigNames() return type has no value type specified in iterable type array. 💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type 85 Method Drupal\entity_delete_log\Form\EntityDeleteLogSettingsForm::buildForm() has parameter $form with no value type specified in iterable type array. 💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type 85 Method Drupal\entity_delete_log\Form\EntityDeleteLogSettingsForm::buildForm() return type has no value type specified in iterable type array. 💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type 126 Method Drupal\entity_delete_log\Form\EntityDeleteLogSettingsForm::submitForm() has no return type specified. 126 Method Drupal\entity_delete_log\Form\EntityDeleteLogSettingsForm::submitForm() has parameter $form with no value type specified in iterable type array. 💡 See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type ------ -------------------------------------------------------------------------------------- [ERROR] Found 16 errors Thanks for using drupal-check! Consider sponsoring the development of the maintainers which make drupal-check possible: - phpstan (ondrejmirtes): https://github.com/sponsors/ondrejmirtes - phpstan-deprecation-rules (ondrejmirtes)): https://github.com/sponsors/ondrejmirtes - phpstan-drupal (mglaman)): https://github.com/sponsors/mglaman - drupal-check (mglaman)): https://github.com/sponsors/mglaman
- 🇮🇳India flutterstack
#9 fixed static analysis issues and now its compatible with d11. kindly review
-
alberto56 →
committed c7b56cd2 on 1.x
Issue #3430157 by project update bot, flutterstack, alberto56: Automated...
-
alberto56 →
committed c7b56cd2 on 1.x
- 🇨🇦Canada alberto56
I have added the enclosed patch. The differences with the patch at #9 are:
* Removed Drupal 9 support as Drupal is no longer active
* I am not adding comments or changing the function signatures of methods which derive from Drupal, thus conforming to Drupal standards.I have also made a new release with this change, 1.2.0