Starterkit changes from 10.1.2 based on
core documentation →
: git diff '10.1.2' '10.2.4' -- core/themes/starterkit_theme
diff --git a/core/themes/starterkit_theme/css/components/details.css b/core/themes/starterkit_theme/css/components/details.css
index a546363a29..04609fd48f 100644
--- a/core/themes/starterkit_theme/css/components/details.css
+++ b/core/themes/starterkit_theme/css/components/details.css
@@ -14,7 +14,7 @@ details {
details > .details-wrapper {
padding: 0.5em 1.5em;
}
-/* @todo Regression: The summary of uncollapsible details are no longer
+/* @todo Regression: The summary of noncollapsible details are no longer
vertically aligned with the .details-wrapper in browsers without native
details support. */
summary {
diff --git a/core/themes/starterkit_theme/templates/block/block--system-branding-block.html.twig b/core/themes/starterkit_theme/templates/block/block--system-branding-block.html.twig
index baa015b177..8814363c52 100644
--- a/core/themes/starterkit_theme/templates/block/block--system-branding-block.html.twig
+++ b/core/themes/starterkit_theme/templates/block/block--system-branding-block.html.twig
@@ -16,7 +16,7 @@
{% block content %}
{% if site_logo %}
<a href="{{ path('<front>') }}" rel="home" class="site-logo">
- <img src="{{ site_logo }}" alt="{{ 'Home'|t }}" />
+ <img src="{{ site_logo }}" alt="{{ 'Home'|t }}" fetchpriority="high" />
</a>
{% endif %}
{% if site_name %}
diff --git a/core/themes/starterkit_theme/templates/content/comment.html.twig b/core/themes/starterkit_theme/templates/content/comment.html.twig
index 5838c62915..41c64901a3 100644
--- a/core/themes/starterkit_theme/templates/content/comment.html.twig
+++ b/core/themes/starterkit_theme/templates/content/comment.html.twig
@@ -4,7 +4,7 @@
* Theme override for comments.
*
* Available variables:
- * - author: Comment author. Can be a link or plain text.
+ * - author: (optional) Comment author. Can be a link or plain text.
* - content: The content-related items for the comment display. Use
* {{ content }} to print them all, or print a subset such as
* {{ content.field_example }}. Use the following code to temporarily suppress
@@ -12,22 +12,24 @@
* @code
* {{ content|without('field_example') }}
* @endcode
- * - created: Formatted date and time for when the comment was created.
- * Preprocess functions can reformat it by calling DateFormatter::format()
- * with the desired parameters on the 'comment.created' variable.
- * - changed: Formatted date and time for when the comment was last changed.
- * Preprocess functions can reformat it by calling DateFormatter::format()
- * with the desired parameters on the 'comment.changed' variable.
+ * - created: (optional) Formatted date and time for when the comment was
+ * created. Preprocess functions can reformat it by calling
+ * DateFormatter::format() with the desired parameters on the
+ * 'comment.created' variable.
+ * - changed: (optional) Formatted date and time for when the comment was last
+ * changed. Preprocess functions can reformat it by calling
+ * DateFormatter::format() with the desired parameters on the
+ * 'comment.changed' variable.
* - permalink: Comment permalink.
- * - submitted: Submission information created from author and created
- * during template_preprocess_comment().
- * - user_picture: The comment author's profile picture.
+ * - submitted: (optional) Submission information created from author and
+ * created during template_preprocess_comment().
+ * - user_picture: (optional) The comment author's profile picture.
* - status: Comment status. Possible values are:
* unpublished, published, or preview.
- * - title: Comment title, linked to the comment.
+ * - title: (optional) Comment title, linked to the comment.
* - attributes: HTML attributes for the containing element.
* The attributes.class may contain one or more of the following classes:
- * - comment: The current template type; e.g., 'theming hook'.
+ * - comment: The current template type; for instance, 'theming hook'.
* - by-anonymous: Comment by an unregistered user.
* - by-{entity-type}-author: Comment by the author of the parent entity,
* eg. by-node-author.
@@ -44,7 +46,7 @@
* - threaded: A flag indicating whether the comments are threaded or not.
*
* These variables are provided to give context about the parent comment (if
- * any):
+ * any, optional):
* - parent_comment: Full parent comment entity (if any).
* - parent_author: Equivalent to author for the parent comment.
* - parent_created: Equivalent to created for the parent comment.
@@ -84,21 +86,23 @@
#}
<mark class="hidden" data-comment-timestamp="{{ new_indicator_timestamp }}"></mark>
- <footer class="comment__meta">
- {{ user_picture }}
- <p class="comment__submitted">{{ submitted }}</p>
+ {% if submitted %}
+ <footer class="comment__meta">
+ {{ user_picture }}
+ <p class="comment__submitted">{{ submitted }}</p>
- {#
- Indicate the semantic relationship between parent and child comments for
- accessibility. The list is difficult to navigate in a screen reader
- without this information.
- #}
- {% if parent %}
- <p class="parent visually-hidden">{{ parent }}</p>
- {% endif %}
+ {#
+ Indicate the semantic relationship between parent and child comments for
+ accessibility. The list is difficult to navigate in a screen reader
+ without this information.
+ #}
+ {% if parent %}
+ <p class="parent visually-hidden">{{ parent }}</p>
+ {% endif %}
- {{ permalink }}
- </footer>
+ {{ permalink }}
+ </footer>
+ {% endif %}
<div{{ content_attributes.addClass('content') }}>
{% if title %}
diff --git a/core/themes/starterkit_theme/templates/form/fieldset.html.twig b/core/themes/starterkit_theme/templates/form/fieldset.html.twig
index db63082e8a..75033edcf1 100644
--- a/core/themes/starterkit_theme/templates/form/fieldset.html.twig
+++ b/core/themes/starterkit_theme/templates/form/fieldset.html.twig
@@ -36,7 +36,7 @@
required ? 'form-required',
]
%}
- {# Always wrap fieldset legends in a <span> for CSS positioning. #}
+ {# Always wrap fieldset legends in a <span> for CSS positioning. #}
<legend{{ legend.attributes }}>
<span{{ legend_span.attributes.addClass(legend_span_classes) }}>{{ legend.title }}</span>
</legend>
diff --git a/core/themes/starterkit_theme/templates/views/views-view-summary-unformatted.html.twig b/core/themes/starterkit_theme/templates/views/views-view-summary-unformatted.html.twig
index 151734e948..975460de2d 100644
--- a/core/themes/starterkit_theme/templates/views/views-view-summary-unformatted.html.twig
+++ b/core/themes/starterkit_theme/templates/views/views-view-summary-unformatted.html.twig
@@ -18,7 +18,7 @@
* @see template_preprocess_views_view_summary_unformatted()
*/
#}
-{% for row in rows %}
+{% for row in rows %}
{{ options.inline ? '<span' : '<div' }} class="views-summary views-summary-unformatted">
{% if row.separator -%}
{{ row.separator }}