Add validation constraints for facets

Created on 15 March 2024, over 1 year ago

Problem/Motivation

Add validation constraints

πŸ“Œ Task
Status

Active

Version

3.0

Component

Code

Created by

πŸ‡§πŸ‡ͺBelgium borisson_ Mechelen, πŸ‡§πŸ‡ͺ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @borisson_
  • Status changed to Needs review over 1 year ago
  • πŸ‡§πŸ‡ͺBelgium borisson_ Mechelen, πŸ‡§πŸ‡ͺ

    Gotten facets from 65% to almost 90% validatable. Will be trying to fix more of this in the future.

  • Status changed to Needs work over 1 year ago
  • πŸ‡§πŸ‡ͺBelgium wim leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί

    Nice!

        facets.facet.owl with the following errors: facets.facet.owl:weight missing
    

    Either schema is incomplete or one 'weight' => $SOMETHING, in a test is superfluous.

  • πŸ‡§πŸ‡ͺBelgium borisson_ Mechelen, πŸ‡§πŸ‡ͺ

    The schema is complete and the tests don't fail locally when running on 11.x, they do fail when checking out 10.1 and 10.2. They pass on 11.x, so it seems like they are failing because we're using the weight type and that's 10.3+ only. I

    think we should have better error message to convey that a type is not found, instead of :weight missing it should say something like: type weight not found. @Wim Leers what do you think, should we open an issue for that? It would've saved me some time debugging to figure that out.

    I'll change those to integer so that we are 10.2 compatible for now

  • Status changed to Needs review over 1 year ago
  • πŸ‡§πŸ‡ͺBelgium borisson_ Mechelen, πŸ‡§πŸ‡ͺ

    Setting this to needs review, we have some test failure, but those are to be expected in the 3.x branch at the moment.

  • πŸ‡ΊπŸ‡ΈUnited States damienmckenna NH, USA

    Related: πŸ› Views filter schema Active

Production build 0.71.5 2024