- Issue created by @jnettik
- Status changed to Needs review
9 months ago 2:56pm 15 March 2024 - 🇺🇸United States pixelwhip
I'm in favor of this and think it would be a DX improvement.
I prefer
@use "../../../libraries/partials/partials" as *;
or even adding the partials path/libraries/partials
a loadPath in the sass configuration so we can shorten it to something like@use "partials" as *;
See https://sass-lang.com/documentation/js-api/interfaces/options/#loadPathsThe reason wildcard includes are frowned upon in JS is it makes it impossible to treeshake dead code paths when the code is bundled – resulting in larger than needed bundle sizes. Since we don't (or at least shouldn't) be putting selectors in our partial files, this is not a constraint we need as the compiled CSS won't. include any output from the partials.
- 🇺🇸United States jnettik Denver, CO
The loadPaths idea is a really good one. Pushed that change to the MR.
- First commit to issue fork.
-
jldust →
committed 80903e7e on 5.x authored by
jnettik →
Issue #3428496 by jnettik, pixelwhip: Simplify Global's partial...
-
jldust →
committed 80903e7e on 5.x authored by
jnettik →
- Status changed to RTBC
9 months ago 5:30pm 20 March 2024 - 🇺🇸United States jldust
This is a great improvement, we have merged this in and will be included in the next tagged release.
- Status changed to Fixed
8 months ago 1:55pm 15 April 2024 - Status changed to Fixed
8 months ago 2:58am 25 April 2024