Automated Drupal 11 compatibility fixes for barcodes

Created on 15 March 2024, 9 months ago
Updated 24 August 2024, 4 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue .

📌 Task
Status

Closed: outdated

Version

2.1

Component

Code

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-120024

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Pipeline finished with Success
    9 months ago
    Total: 151s
    #120077
  • This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-120835

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Pipeline finished with Success
    9 months ago
    Total: 151s
    #120879
  • Status changed to RTBC 5 months ago
  • 🇨🇦Canada floydm

    This patch seems to be all that is necessary to get barcode working under D11.

    There is one test failure, but I see that test failing in D10 too. The error:

    Drupal\Tests\barcodes\Functional\BarcodeBlockTest::testBarcodeFormat with data set "PNG display format." ('PNG', '023130', '')
    Behat\Mink\Exception\ExpectationException: The string "" was not found anywhere in the HTML response of the current page.

    Could we get a D11 compatible release soon?

  • Status changed to Active 5 months ago
  • 🇺🇸United States tr Cascadia

    No, there's more to D11 compatibility than just adding ||^11 to the .info.yml. And it has to be done in a way that doesn't break compatibility with other Drupal core versions.

    D11 support will come in the 2.1.x branch. See 📌 Update external barcodes library tecnickcom/tc-lib-barcode Needs review .

    I am working on it and have made most of the necessary changes locally, but I haven't pushed them out yet. I have a lot of modules that I maintain that I am upgrading to D11, so it will take a while for me to finish them all.

  • 🇨🇦Canada floydm

    Just adding ^11 was enough to get it to work for me today in a vanilla D11 install. I tried a handful of barcode formats on a short text field and they worked fine, then I tried running the tests where I got the same failure as I get under D10. Obviously not exhaustive testing, but an option for folks (like me) with simple use cases.

    Thanks for your work on the library upgrade.

  • Status changed to Closed: outdated 4 months ago
  • 🇺🇸United States tr Cascadia

    The 2.1.x branch has been passing the D11 and D10 tests since at least 3 August. A 2.1.0 release will be made as soon as Change the extension from svg to png using |barcode Needs review is finished and after the documentation guide at https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... has had a little more work done on it.

    Until then, anyone who needs this module for Drupal 11 should use the -dev release for 2.1.0.

Production build 0.71.5 2024