Contrib.social

Issues with tax rate and shipping cost

Open on Drupal.org →
Created on 14 March 2024, about 1 year ago

Problem/Motivation

I created an in-store pickup method by extending PickupShippingMethodBase like in the demo, and while testing it looks like there are a couple of issues with the checkout pane.

1. When entering the checkout form, if another non-pickup shipping method is selected by default its rate isn't calculated. The user would need to pick a different method and then re-select the original method for its rate to be added to the order summary.

2. Selecting a different address doesn't recalculate tax rates. We're only charging sales tax for one US state, and picking an address with a different state doesn't clear the tax.

I thought it might be due to PickupCapableShippingInformation force-setting auto_recalculate to false, but when change the code to force it back to true it doesn't change the behavior.

It looks like maybe more of the logic from commerce_shipping's buildPaneForm may need to be pulled into this module?

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

🇺🇸United States karlshea Minneapolis 🇺🇸

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @karlshea
  • Comment 21 days ago →
    🇧🇪Belgium rgeerolf Belgium 🇧🇪🇪🇺

    I'm experiencing the same problem. However, in my setup at least, it doesn't matter if the default shipping method is non-pickup or not. For testing purposes, I added a rate to the pickup shipping method and the same problem occurred (no added shipping cost when entering the checkout). The shipping cost is only after changing the shipping method.

    When you choose a shipping method and return, the shipping cost is added. It's only the first time when no shipping method was previously selected.

  • Comment 21 days ago →
    🇭🇺Hungary djg_tram

    Isn't this the same as https://www.drupal.org/project/commerce_shipping_pickup_api/issues/3406396 🐛 Dropdown or map not showing when default shipping method Active ?

    As I also mentioned in another issue, I was working on some bigger changes because I'm involved with a dependent module that also required adaptation the the framework. That seems to have settled by now, so I'll upload the current state as a dev module, I'll not yet really ready to publish is before I get feedback. But this also contains the fix for the first appearance.

  • Comment 21 days ago →
    🇧🇪Belgium rgeerolf Belgium 🇧🇪🇪🇺

    Thank you for the updated dev release. Haven't tested anything else, but this issue seems fixed with commit 482e53e3.

  • Comment 21 days ago →
    🇭🇺Hungary djg_tram

    Yes, but there will be more changes, even with these lines — I hope without regression. :-)

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024